Move Get/SetScrollOffset methods from WebFrame to WebLocalFrame.

third_party/WebKit/Source/core/frame/FullscreenController.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 56 matching lines @@
 void FullscreenController::DidEnterFullscreen() {
   // |Browser::EnterFullscreenModeForTab()| can enter fullscreen without going
   // through |Fullscreen::requestFullscreen()|, in which case there will be no
   // fullscreen element. Do nothing.
   if (state_ != State::kEnteringFullscreen)
     return;
 
   UpdatePageScaleConstraints(false);
   web_view_base_->SetPageScaleFactor(1.0f);
   if (web_view_base_->MainFrame()->IsWebLocalFrame())
-    web_view_base_->MainFrame()->SetScrollOffset(WebSize());
+    web_view_base_->MainFrame()->ToWebLocalFrame()->SetScrollOffset(WebSize());

[dcheng, 2017/06/16 23:52:20]

+alexmos, is there anything more we need to do here for OOPIF?

[alexmos, 2017/06/17 00:04:02]

I don't think so - I think these only need to be done when the main frame is
local. 
(With OOPIF fullscreen, this will be called in each renderer, and I think we
only care about clearing and then restoring these to their original values in
the main frame renderer.)

   web_view_base_->SetVisualViewportOffset(FloatPoint());
 
   state_ = State::kFullscreen;
 
   // Notify all local frames that we have entered fullscreen.
   for (Frame* frame = web_view_base_->GetPage()->MainFrame(); frame;
        frame = frame->Tree().TraverseNext()) {
     if (!frame->IsLocalFrame())
       continue;
     if (Document* document = ToLocalFrame(frame)->GetDocument()) {
@@ skipping 56 matching lines @@
 
   // We need to store these values here rather than in |didEnterFullscreen()|
   // since by the time the latter is called, a Resize has already occured,
   // clamping the scroll offset. Don't save values if we're still waiting to
   // restore a previous set. This can happen if we exit and quickly reenter
   // fullscreen without performing a layout.
   if (state_ == State::kInitial) {
     initial_page_scale_factor_ = web_view_base_->PageScaleFactor();
     initial_scroll_offset_ =
         web_view_base_->MainFrame()->IsWebLocalFrame()
-            ? web_view_base_->MainFrame()->GetScrollOffset()
+            ? web_view_base_->MainFrame()->ToWebLocalFrame()->GetScrollOffset()
             : WebSize();
     initial_visual_viewport_offset_ = web_view_base_->VisualViewportOffset();
     initial_background_color_override_enabled_ =
         web_view_base_->BackgroundColorOverrideEnabled();
     initial_background_color_override_ =
         web_view_base_->BackgroundColorOverride();
   }
 
   // If already entering fullscreen, just wait.
   if (state_ == State::kEnteringFullscreen)
@@ skipping 87 matching lines @@
     }
   }
 }
 
 void FullscreenController::DidUpdateLayout() {
   if (state_ != State::kNeedsScrollAndScaleRestore)
     return;
 
   web_view_base_->SetPageScaleFactor(initial_page_scale_factor_);
   if (web_view_base_->MainFrame()->IsWebLocalFrame()) {
-    web_view_base_->MainFrame()->SetScrollOffset(
+    web_view_base_->MainFrame()->ToWebLocalFrame()->SetScrollOffset(
         WebSize(initial_scroll_offset_));
   }
   web_view_base_->SetVisualViewportOffset(initial_visual_viewport_offset_);
   // Background color override was already restored when
   // fullscreenElementChanged([..], nullptr) was called while exiting.
 
   state_ = State::kInitial;
 }
 
 void FullscreenController::UpdatePageScaleConstraints(bool remove_constraints) {
@@ skipping 14 matching lines @@
   // again to ensure the final constraints pick up the latest contents size.
   web_view_base_->DidChangeContentsSize();
   if (web_view_base_->MainFrameImpl() &&
       web_view_base_->MainFrameImpl()->GetFrameView())
     web_view_base_->MainFrameImpl()->GetFrameView()->SetNeedsLayout();
 
   web_view_base_->UpdateMainFrameLayoutSize();
 }
 
 }  // namespace blink