Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5003)

Unified Diff: chrome/browser/resources/vulcanize.gni

Issue 2936333002: WebUI: Replace vulcanize with polymer-bundler (Closed)
Patch Set: Address comments. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/lazy_load.html ('k') | chrome/browser/resources/vulcanize_gn.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/vulcanize.gni
diff --git a/chrome/browser/resources/vulcanize.gni b/chrome/browser/resources/vulcanize.gni
index 69db5294cc8fa73b74f5f1ad3bb0a197ffcf512c..5555d35f7127d4fe7c82f9528dbdd91b9597e930 100644
--- a/chrome/browser/resources/vulcanize.gni
+++ b/chrome/browser/resources/vulcanize.gni
@@ -34,12 +34,16 @@ template("vulcanize") {
]
# This depfile is generated by vulcanize_gn.py
- depfile = "${target_gen_dir}/${invoker.html_out_file}.d"
+ depfile = "${target_gen_dir}/${target_name}.d"
+
+ outputs = []
+ foreach(_out, invoker.html_out_files) {
+ outputs += [ "$target_gen_dir/$_out" ]
+ }
+ foreach(_out, invoker.js_out_files) {
+ outputs += [ "$target_gen_dir/$_out" ]
+ }
- outputs = [
- "$target_gen_dir/${invoker.html_out_file}",
- "$target_gen_dir/${invoker.js_out_file}",
- ]
deps = invoker.deps
# Note that we have to manually pass the sources to our script if the
@@ -47,12 +51,6 @@ template("vulcanize") {
args = [
"--host",
invoker.host,
- "--html_in_file",
- invoker.html_in_file,
- "--html_out_file",
- invoker.html_out_file,
- "--js_out_file",
- invoker.js_out_file,
"--input",
invoker.input,
"--out_folder",
@@ -61,6 +59,10 @@ template("vulcanize") {
rebase_path(depfile, root_build_dir),
]
+ args += [ "--html_in_files" ] + invoker.html_in_files
+ args += [ "--html_out_files" ] + invoker.html_out_files
+ args += [ "--js_out_files" ] + invoker.js_out_files
+
if (defined(invoker.excludes)) {
args += [ "--exclude" ] + invoker.excludes
}
« no previous file with comments | « chrome/browser/resources/settings/lazy_load.html ('k') | chrome/browser/resources/vulcanize_gn.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698