Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 29363005: Remove LayoutTest animations/fill-mode-forwards.html (Closed)

Created:
7 years, 2 months ago by Steve Block
Modified:
7 years, 2 months ago
Reviewers:
dstockwell
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Remove LayoutTest animations/fill-mode-forwards.html This test relies on receiving a specific number of animationiteration events. However, in both the legacy and Web Animations implementations, we do not guarantee that the correct number of these events is fired. See crbug.com/275263. We have no immediate plans to fix this and the flakiness dashboard shows timeouts for this test with both implementations. The test was added to test a particular bug fix in the legacy animations implementation (http://trac.webkit.org/changeset/117216) and has little to do with forwards fill. Most cases of forwards-fill testing (excluding play-state and events) is covered by timing-model.html This test therefore adds little value and should be removed. We can consider reinstating it if and when the underlying bug is fixed. BUG=275263 R=dstockwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160286

Patch Set 1 #

Patch Set 2 : Upload flakiness #

Patch Set 3 : Upload sucks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -99 lines) Patch
M LayoutTests/TestExpectations View 1 2 chunks +0 lines, -2 lines 0 comments Download
D LayoutTests/animations/fill-mode-forwards.html View 1 chunk +0 lines, -96 lines 0 comments Download
D LayoutTests/animations/fill-mode-forwards-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Steve Block
7 years, 2 months ago (2013-10-22 23:39:34 UTC) #1
dstockwell
Still can't see the change :(
7 years, 2 months ago (2013-10-22 23:42:20 UTC) #2
dstockwell
lgtm Description could also note that most cases of forwards-fill testing (exclusing play-state and events) ...
7 years, 2 months ago (2013-10-23 00:10:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/29363005/210001
7 years, 2 months ago (2013-10-23 00:18:23 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 02:31:21 UTC) #5
Message was sent while issue was closed.
Change committed as 160286

Powered by Google App Engine
This is Rietveld 408576698