third_party/WebKit/Source/core/dom/Element.cpp - Issue 2936283003: Update CSSOM SmoothScroll Web Platform Test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2936283003: Update CSSOM SmoothScroll Web Platform Test (Closed)

Patch Set: Update the tests and idl Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 2bff5dd11379c36c67f38b0ed22ff2aca0c99c7e..afd4948a7544c2692ba044e5eac5fba98e8331c9 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -467,6 +467,9 @@ void Element::scrollIntoView(ScrollIntoViewOptionsOrBoolean arg) {

options.behavior() == "smooth") {

options.setBehavior("instant");

}

+ } else if (arg.isNull()) {

foolip 2017/06/16 08:20:33 This can be removed again because the argument can

+ options.setBlock("start");

+ options.setInlinePosition("nearest");

}

scrollIntoViewWithOptions(options);

}