Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2936233003: Remove Compiler.mainApp and Compiler.mainFunction (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove Compiler.mainApp and Compiler.mainFunction This prepares for switching between K and J elements between resolution and codegen. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/795e078f21c195fcf509cd9e29671ef119f336d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -95 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 9 chunks +12 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 3 chunks +8 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/task.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 6 chunks +11 lines, -4 lines 0 comments Download
M pkg/compiler/tool/perf.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/array_tracing_mirror_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/assert_message_throw_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/benign_error_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 4 chunks +11 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/constant_expression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/container_mask_equal_test.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/deferred_dont_inline_deferred_constants_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/deferred_dont_inline_deferred_globals_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_mirrors_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/deferred_not_in_main_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/dictionary_types_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/expect_annotations_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/inference/inference_test_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/instantiated_classes_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/constructors_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/helper.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/no_such_method_enabled_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/related_types_test.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 3 chunks +7 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/native_data_test.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_callers_test.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/source_map_name_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/trust_type_annotations2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/use_checks_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/value_range3_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-15 12:10:27 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 6 months ago (2017-06-15 18:31:43 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-16 11:00:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
795e078f21c195fcf509cd9e29671ef119f336d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698