Issue 2936223002: Update status file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2936223002: Update status file. (Closed)

Created:
3 years, 6 months ago by ahe

Modified:
3 years, 6 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update status file. Committed: https://github.com/dart-lang/sdk/commit/3fd4b27c9d6e3e53cb3a08381a5b930af773a0ca

Patch Set 1 #

Total comments: 1

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

Committed patchset #1 (id:1) manually as 3fd4b27c9d6e3e53cb3a08381a5b930af773a0ca (presubmit successful).

3 years, 6 months ago (2017-06-14 16:37:38 UTC) #4

Paul Berry

3 years, 6 months ago (2017-06-14 17:19:52 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/2936223002/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/2936223002/diff/1/tests/lib/lib.status#newcod...
tests/lib/lib.status:556: mirrors/metadata_allowed_values_test/16: Skip # Flaky,
crashes.
Does this crash in the front end or at runtime?

If it crashes in the front end, that's a front end bug and we should figure out
why it's happening.

If it crashes at runtime, maybe we should change this to "RuntimeError, Pass" so
that at least we continue to validate that the front end doesn't crash.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages