Issue 2936203002: Unbind canonical name of getter after renaming it in closure conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2936203002: Unbind canonical name of getter after renaming it in closure conversion (Closed)

Created:
3 years, 6 months ago by Dmitry Stefantsov

Modified:
3 years, 6 months ago

Reviewers:
ahe, karlklose

CC:
reviews_dartlang.org, Kevin Millikin (Google), kustermann

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pkg/kernel/lib/transformations/closure/converter.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

karlklose

Is there a way to write a regression test for this? LGTM

3 years, 6 months ago (2017-06-15 08:48:12 UTC) #3

Dmitry Stefantsov

On 2017/06/15 08:48:12, karlklose wrote: > Is there a way to write a regression test ...

3 years, 6 months ago (2017-06-15 08:56:13 UTC) #4

Dmitry Stefantsov

3 years, 6 months ago (2017-06-15 08:58:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
504f55c04310a46fc19965d738bc35cceaf14cec (presubmit successful).