update statement completion for fasta scanner

update statement completion for fasta scanner

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/305f358fa47aa15aa336bf1cb8527508730b786d

[danrubel, 2017-06-14 03:11:54]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com, messick@google.com

[Brian Wilkerson, 2017-06-14 04:14:31]

lgtm

https://codereview.chromium.org/2936143002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
(right):

https://codereview.chromium.org/2936143002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:332:
if (expr == null) {
You could also use `??` to avoid the extra weight of an `if` statement.

https://codereview.chromium.org/2936143002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:435:
// Because of this, check for length == 0 rather than isSynthetic.
If `isSynthetic` doesn't always return a valid result, then can we either (a)
fix it so that it does (my preference), or (b) remove / deprecate it so that
people won't use it incorrectly?

[danrubel, 2017-06-14 06:05:42]

https://codereview.chromium.org/2936143002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart
(right):

https://codereview.chromium.org/2936143002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:332:
if (expr == null) {
On 2017/06/14 04:14:31, Brian Wilkerson wrote:
> You could also use `??` to avoid the extra weight of an `if` statement.

Good point. Done.

[danrubel, 2017-06-14 15:15:55]

Description was changed from

==========
update statement completion for fasta scanner
==========

to

==========
update statement completion for fasta scanner

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/305f358fa47aa15aa336bf1cb8527508730b786d
==========

[danrubel, 2017-06-14 15:15:58]

Committed patchset #2 (id:20001) manually as
305f358fa47aa15aa336bf1cb8527508730b786d (presubmit successful).