ChromeOS login webui refactoring: split user selection/gaia login screens.

ChromeOS login webui refactoring: split user selection/gaia login screens.
Phase one : introduce future screen classes before moving code from handler.

BUG=373314
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272870

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272948

[Nikita (slow), 2014-05-20 12:14:29]

lgtm

https://codereview.chromium.org/293613003/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/screens/gaia_screen.h (right):

https://codereview.chromium.org/293613003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/gaia_screen.h:17: class GaiaScreen {
nit: Comment

https://codereview.chromium.org/293613003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/gaia_screen.h:17: class GaiaScreen {
Are you planning to define something like GaiaScreenActor interface?

https://codereview.chromium.org/293613003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/gaia_screen.h:21: virtual void
SetHandler(LoginDisplayWebUIHandler* handler);
Please remove virtual for now since there's no interface defined yet.

https://codereview.chromium.org/293613003/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/screens/user_selection_screen.cc (right):

https://codereview.chromium.org/293613003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/user_selection_screen.cc:41: //
ToDo(antrim):
nit: Remove this commented code.

https://codereview.chromium.org/293613003/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/screens/user_selection_screen.h (right):

https://codereview.chromium.org/293613003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/user_selection_screen.h:18: class
UserSelectionScreen {
nit: Comment

https://codereview.chromium.org/293613003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/user_selection_screen.h:18: class
UserSelectionScreen {
Are you planning to define something like UserSelectionScreenActor interface?

https://codereview.chromium.org/293613003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/screens/user_selection_screen.h:25: virtual void
Init(const UserList& users);
Please remove virtual for now since there's no interface defined yet.

[Denis Kuznetsov (DE-MUC), 2014-05-20 13:19:00]

https://chromiumcodereview.appspot.com/293613003/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/screens/gaia_screen.h (right):

https://chromiumcodereview.appspot.com/293613003/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screens/gaia_screen.h:17: class GaiaScreen {
On 2014/05/20 12:14:29, Nikita Kostylev wrote:
> nit: Comment

Done.

https://chromiumcodereview.appspot.com/293613003/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screens/gaia_screen.h:17: class GaiaScreen {
On 2014/05/20 12:14:29, Nikita Kostylev wrote:
> Are you planning to define something like GaiaScreenActor interface?
Yes, after "signin_screen_handler" is split into 3 parts.

https://chromiumcodereview.appspot.com/293613003/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screens/gaia_screen.h:21: virtual void
SetHandler(LoginDisplayWebUIHandler* handler);
On 2014/05/20 12:14:29, Nikita Kostylev wrote:
> Please remove virtual for now since there's no interface defined yet.

Done.

https://chromiumcodereview.appspot.com/293613003/diff/1/chrome/browser/chrome...
File chrome/browser/chromeos/login/screens/user_selection_screen.h (right):

https://chromiumcodereview.appspot.com/293613003/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screens/user_selection_screen.h:18: class
UserSelectionScreen {
On 2014/05/20 12:14:29, Nikita Kostylev wrote:
> nit: Comment

Done.

https://chromiumcodereview.appspot.com/293613003/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screens/user_selection_screen.h:18: class
UserSelectionScreen {
On 2014/05/20 12:14:29, Nikita Kostylev wrote:
> nit: Comment

Done.

https://chromiumcodereview.appspot.com/293613003/diff/1/chrome/browser/chrome...
chrome/browser/chromeos/login/screens/user_selection_screen.h:25: virtual void
Init(const UserList& users);
On 2014/05/20 12:14:29, Nikita Kostylev wrote:
> Please remove virtual for now since there's no interface defined yet.

Done.

[Denis Kuznetsov (DE-MUC), 2014-05-20 13:19:07]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-05-20 13:20:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/293613003/20001

[commit-bot: I haz the power, 2014-05-20 16:01:17]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-20 17:17:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 17:17:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Denis Kuznetsov (DE-MUC), 2014-05-20 19:48:54]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-05-20 19:50:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/293613003/40001

[commit-bot: I haz the power, 2014-05-20 20:56:59]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-05-20 20:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 20:59:35]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[Denis Kuznetsov (DE-MUC), 2014-05-21 09:44:14]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-05-21 09:46:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/293613003/40001

[Denis Kuznetsov (DE-MUC), 2014-05-21 12:37:24]

The CQ bit was unchecked by antrim@chromium.org

[Denis Kuznetsov (DE-MUC), 2014-05-21 12:41:04]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-05-21 19:58:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/293613003/60001

[commit-bot: I haz the power, 2014-05-22 02:05:04]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/7756)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10889)

[commit-bot: I haz the power, 2014-05-22 02:10:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 02:10:21]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[Denis Kuznetsov (DE-MUC), 2014-05-26 16:25:08]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-05-26 16:27:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/293613003/100001

[commit-bot: I haz the power, 2014-05-26 20:06:06]

Change committed as 272870

[sergeyv, 2014-05-27 11:15:47]

A revert of this CL has been created in
https://codereview.chromium.org/298193002/ by sergeyv@chromium.org.

The reason for reverting is: Speculative Revert: looks like it can cause failure
on chromium.chromiumos:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20C....

[Denis Kuznetsov (DE-MUC), 2014-05-27 11:42:30]

On 2014/05/27 11:15:47, sergeyv wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/298193002/ by mailto:sergeyv@chromium.org.
> 
> The reason for reverting is: Speculative Revert: looks like it can cause
failure
> on chromium.chromiumos:
>
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20C....

This IS a speculative revert. Committing again.

[Denis Kuznetsov (DE-MUC), 2014-05-27 11:42:46]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2014-05-27 11:42:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/antrim@chromium.org/293613003/100001

[commit-bot: I haz the power, 2014-05-27 11:44:04]

Change committed as 272948