Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 293613002: Add a minimum offset for the OOP PDF toolbar (Closed)

Created:
6 years, 7 months ago by raymes
Modified:
6 years, 7 months ago
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Add a minimum offset for the OOP PDF toolbar On platforms which have an overlay scrollbar (namely Mac) the toolbar in OOP PDF appears to be too low to the bottom and right of the screen. This adds a minimum offset for the toolbar. BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272367

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
raymes
6 years, 7 months ago (2014-05-20 06:37:14 UTC) #1
koz (OOO until 15th September)
lgtm
6 years, 7 months ago (2014-05-20 23:45:13 UTC) #2
raymes
+arv for OWNERS On Wed, May 21, 2014 at 9:45 AM, <koz@chromium.org> wrote: > lgtm ...
6 years, 7 months ago (2014-05-21 00:07:55 UTC) #3
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 7 months ago (2014-05-22 00:26:27 UTC) #4
raymes
The CQ bit was unchecked by raymes@chromium.org
6 years, 7 months ago (2014-05-22 00:26:30 UTC) #5
raymes
+arv for OWNERS
6 years, 7 months ago (2014-05-22 00:26:45 UTC) #6
arv (Not doing code reviews)
LGTM
6 years, 7 months ago (2014-05-22 00:49:04 UTC) #7
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 7 months ago (2014-05-22 00:49:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/293613002/20001
6 years, 7 months ago (2014-05-22 00:53:30 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 10:39:55 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 10:42:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9721)
6 years, 7 months ago (2014-05-22 10:42:08 UTC) #12
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 7 months ago (2014-05-22 23:43:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/293613002/20001
6 years, 7 months ago (2014-05-22 23:43:50 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 23:46:06 UTC) #15
Message was sent while issue was closed.
Change committed as 272367

Powered by Google App Engine
This is Rietveld 408576698