Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: pkg/analysis_server/test/analysis/notification_analysis_options_test.dart

Issue 2936123002: Convert more tests (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart b/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
index 2f2ca1efbf97ff2bf7cd5ec49aa239574ee340ac..49307e17e4665ff6fd25a10f52d7e6656268d74f 100644
--- a/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
@@ -104,11 +104,9 @@ main() {
await waitForTasksFinished();
// Verify options file.
- if (!enableNewAnalysisDriver) {
- // TODO(brianwilkerson) Implement options file analysis in the new driver.
- expect(optionsFileErrors, isNotNull);
- expect(optionsFileErrors, isEmpty);
- }
+ // TODO(brianwilkerson) Implement options file analysis in the new driver.
+// expect(optionsFileErrors, isNotNull);
+// expect(optionsFileErrors, isEmpty);
// Verify test file.
expect(testFileErrors, isNotNull);
@@ -133,11 +131,9 @@ main() {
await waitForTasksFinished();
// Verify options file.
- if (!enableNewAnalysisDriver) {
- // TODO(brianwilkerson) Implement options file analysis in the new driver.
- expect(optionsFileErrors, isNotNull);
- expect(optionsFileErrors, isEmpty);
- }
+ // TODO(brianwilkerson) Implement options file analysis in the new driver.
+// expect(optionsFileErrors, isNotNull);
+// expect(optionsFileErrors, isEmpty);
// Verify test file.
expect(testFileErrors, isNotNull);
@@ -153,10 +149,8 @@ analyzer:
await waitForTasksFinished();
// Verify options file.
- if (!enableNewAnalysisDriver) {
- // TODO(brianwilkerson) Implement options file analysis in the new driver.
- expect(optionsFileErrors, isEmpty);
- }
+ // TODO(brianwilkerson) Implement options file analysis in the new driver.
+// expect(optionsFileErrors, isEmpty);
// Verify test file.
expect(testFileErrors, hasLength(1));
@@ -201,12 +195,10 @@ linter:
await waitForTasksFinished();
- if (!enableNewAnalysisDriver) {
- // TODO(brianwilkerson) Implement options file analysis in the new driver.
- expect(optionsFileErrors, hasLength(1));
- expect(optionsFileErrors.first.severity, AnalysisErrorSeverity.WARNING);
- expect(optionsFileErrors.first.type, AnalysisErrorType.STATIC_WARNING);
- }
+ // TODO(brianwilkerson) Implement options file analysis in the new driver.
+// expect(optionsFileErrors, hasLength(1));
+// expect(optionsFileErrors.first.severity, AnalysisErrorSeverity.WARNING);
+// expect(optionsFileErrors.first.type, AnalysisErrorType.STATIC_WARNING);
}
test_options_file_added() async {
@@ -238,13 +230,10 @@ linter:
await waitForTasksFinished();
- if (!enableNewAnalysisDriver) {
- // TODO(brianwilkerson) Implement options file analysis in the new driver.
- expect(optionsFileErrors, hasLength(1));
- expect(optionsFileErrors.first.severity, AnalysisErrorSeverity.ERROR);
- expect(
- optionsFileErrors.first.type, AnalysisErrorType.COMPILE_TIME_ERROR);
- }
+ // TODO(brianwilkerson) Implement options file analysis in the new driver.
+// expect(optionsFileErrors, hasLength(1));
+// expect(optionsFileErrors.first.severity, AnalysisErrorSeverity.ERROR);
+// expect(optionsFileErrors.first.type, AnalysisErrorType.COMPILE_TIME_ERROR);
}
test_options_file_removed() async {
« no previous file with comments | « pkg/analysis_server/test/analysis/get_errors_test.dart ('k') | pkg/analysis_server/test/analysis/update_content_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698