Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2936063002: Handle named mixin application in emitter (Closed)

Created:
3 years, 6 months ago by Emily Fortuna
Modified:
3 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, turnidge, rmacnak, keertip
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle named mixin application in emitter Fixes regression in language/regress_18713_test with --csp Closes #29844 Closes #29843 This reapplies Johnni's change from here: https://codereview.chromium.org/2934783002/ I am submitting it instead of Johnni because without this change we are blocking the new dart update internally in Google. BUG= TBR Committed: https://github.com/dart-lang/sdk/commit/0753ac689eb3c89bbf8ee88e76e9dda23b59451d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -38 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +20 lines, -0 lines 0 comments Download
D pkg/compiler/lib/src/js_emitter/helpers.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 5 chunks +12 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 5 chunks +25 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/task.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Emily Fortuna
Committed patchset #1 (id:1) manually as 0753ac689eb3c89bbf8ee88e76e9dda23b59451d (presubmit successful).
3 years, 6 months ago (2017-06-13 21:23:25 UTC) #4
Emily Fortuna
3 years, 6 months ago (2017-06-13 21:23:39 UTC) #5
Johnni Winther
3 years, 6 months ago (2017-06-14 07:46:05 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698