Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2936043002: Chase imports in analyzer's front_end_inference_test. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -26 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 3 chunks +34 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +1 line, -9 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_consts_transitively_2.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_consts_transitively_2.dart.strong.expect View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_consts_transitively_2_a.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_consts_transitively_2_a.dart.strong.expect View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_from_variables_in_cycle_libs_when_flag_is_on.dart View 1 chunk +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/infer_from_variables_in_cycle_libs_when_flag_is_on.dart.strong.expect View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_from_variables_in_cycle_libs_when_flag_is_on2.dart View 2 chunks +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/infer_from_variables_in_cycle_libs_when_flag_is_on2.dart.strong.expect View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_from_variables_in_non_cycle_imports_with_flag.dart View 1 chunk +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/infer_from_variables_in_non_cycle_imports_with_flag.dart.strong.expect View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_from_variables_in_non_cycle_imports_with_flag2.dart View 1 chunk +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/infer_from_variables_in_non_cycle_imports_with_flag2.dart.strong.expect View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_statics_transitively.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_statics_transitively.dart.strong.expect View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_statics_transitively3.dart View 2 chunks +4 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_statics_transitively3.dart.strong.expect View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_statics_transitively_a.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/inference/infer_statics_transitively_a.dart.strong.expect View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_in_library_cycle.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-13 20:54:32 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-13 20:59:38 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-13 21:28:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
211e578273e33ca38addd521792f9203d3c7e337 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698