Chromium Code Reviews| Index: chrome/test/data/webui/settings/site_details_tests.js |
| diff --git a/chrome/test/data/webui/settings/site_details_tests.js b/chrome/test/data/webui/settings/site_details_tests.js |
| index 95517a16dace599e0e6d8ca76acdd6e03e506193..7f4283d666d7610650c2a1ec2e26b45e79f1be5b 100644 |
| --- a/chrome/test/data/webui/settings/site_details_tests.js |
| +++ b/chrome/test/data/webui/settings/site_details_tests.js |
| @@ -36,7 +36,7 @@ suite('SiteDetails', function() { |
| embeddingOrigin: 'https://foo-allow.com:443', |
| origin: 'https://foo-allow.com:443', |
| setting: 'allow', |
| - source: 'preference', |
| + source: 'extension', |
| }, |
| ], |
| cookies: [ |
| @@ -51,8 +51,8 @@ suite('SiteDetails', function() { |
| { |
| embeddingOrigin: 'https://foo-allow.com:443', |
| origin: 'https://foo-allow.com:443', |
| - setting: 'allow', |
| - source: 'preference', |
| + setting: 'block', |
| + source: 'policy', |
| }, |
| ], |
| images: [ |
| @@ -141,15 +141,30 @@ suite('SiteDetails', function() { |
| Polymer.dom(parent).appendChild(api); |
| browserProxy.setPrefs(prefs); |
| - testElement.site = { |
| - origin: 'https://foo-allow.com:443', |
| - displayName: 'https://foo-allow.com:443', |
| - embeddingOrigin: '', |
| - }; |
| + testElement.origin = 'https://foo-allow.com:443'; |
| Polymer.dom.flush(); |
| - // expect usage to be rendered |
| + // Expect usage to be rendered. |
| assertTrue(!!testElement.$$('#usage')); |
| }); |
| + |
| + test('correct pref settings are shown', function() { |
| + browserProxy.setPrefs(prefs); |
| + testElement.origin = 'https://foo-allow.com:443'; |
| + |
| + testElement.root.querySelectorAll('site-details-permission') |
| + .forEach(function(siteDetailsPermission) { |
| + browserProxy.whenCalled('getCategoryPermissionForOrigin') |
|
raymes
2017/06/19 04:13:12
As we discussed I think the test might have to be
Patti Lor
2017/06/20 08:25:54
Done, thank you for bringing this up because I wou
|
| + .then(function() { |
| + // Verify settings match the values specified in |prefs|. |
| + var setting = 'allow'; |
| + if (siteDetailsPermission.site.category == 'location') |
| + setting = 'block'; |
| + assertEquals(setting, siteDetailsPermission.site.setting); |
| + assertEquals(setting, siteDetailsPermission.$.permission.value); |
| + browserProxy.resetResolver('getCategoryPermissionForOrigin'); |
| + }); |
| + }); |
| + }); |
| }); |