chrome/browser/resources/settings/site_settings/site_details_permission.js - Issue 2936003003: MD Settings: Set all content setting values in Site Details Javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_details_permission.js

Issue 2936003003: MD Settings: Set all content setting values in Site Details Javascript. (Closed)

Patch Set: Review comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_details.js ('k') | chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_details_permission.js

diff --git a/chrome/browser/resources/settings/site_settings/site_details_permission.js b/chrome/browser/resources/settings/site_settings/site_details_permission.js

index 17ca6c0d2ea30a0ac139c6d9ff0eb57538f185e9..2d799f5d5cff534280b8ad14af557d97721ddbd0 100644

--- a/chrome/browser/resources/settings/site_settings/site_details_permission.js

+++ b/chrome/browser/resources/settings/site_settings/site_details_permission.js

@@ -48,22 +48,12 @@ Polymer({

/**

- * Sets the site to display.

+ * Updates the drop-down value after |site| has changed.

* @param {!SiteException} site The site to display.

* @private

siteChanged_: function(site) {

- this.browserProxy.getExceptionList(this.category)

- .then(function(exceptionList) {

- for (var i = 0; i < exceptionList.length; ++i) {

- if (exceptionList[i].embeddingOrigin == site.embeddingOrigin &&

- this.sameOrigin_(exceptionList[i].origin, site.origin)) {

- this.$.permission.value = exceptionList[i].setting;

- break;

- }

- }.bind(this));

+ this.$.permission.value = site.setting;

/**