Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: chrome/browser/resources/settings/site_settings/site_details.html

Issue 2936003003: MD Settings: Set all content setting values in Site Details Javascript. (Closed)
Patch Set: Review comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/site_details.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_details.html
diff --git a/chrome/browser/resources/settings/site_settings/site_details.html b/chrome/browser/resources/settings/site_settings/site_details.html
index 540c4bd46077f81fe6c59851f2da9e7c27df3e64..e5561deea3eff8cbf7fe2637e87d674ef8602148 100644
--- a/chrome/browser/resources/settings/site_settings/site_details.html
+++ b/chrome/browser/resources/settings/site_settings/site_details.html
@@ -39,9 +39,10 @@
<div class="settings-box first">
<div class="favicon-image"
- style$="[[computeSiteIcon(site.origin)]]">
+ style$="[[computeSiteIcon(origin)]]">
</div>
- <div class="middle">[[site.displayName]]</div>
+ <!-- TODO(patricialor): This should show the origin's display name. -->
+ <div class="middle">[[origin]]</div>
</div>
<template is="dom-if" if="[[storedData_]]">
<div id="usage">
@@ -63,55 +64,52 @@
</div>
<div class="list-frame">
<site-details-permission category="{{ContentSettingsTypes.COOKIES}}"
- icon="settings:cookie" id="cookies" label="$i18n{siteSettingsCookies}"
- site="[[site]]">
+ icon="settings:cookie" id="cookies"
+ label="$i18n{siteSettingsCookies}">
</site-details-permission>
<site-details-permission category="{{ContentSettingsTypes.GEOLOCATION}}"
icon="settings:location-on" id="geolocation"
- label="$i18n{siteSettingsLocation}" site="[[site]]">
+ label="$i18n{siteSettingsLocation}">
</site-details-permission>
<site-details-permission category="{{ContentSettingsTypes.CAMERA}}"
icon="settings:videocam" id="camera"
- label="$i18n{siteSettingsCamera}" site="[[site]]">
+ label="$i18n{siteSettingsCamera}">
</site-details-permission>
<site-details-permission category="{{ContentSettingsTypes.MIC}}"
icon="settings:mic" id="mic"
- label="$i18n{siteSettingsMic}" site="[[site]]">
+ label="$i18n{siteSettingsMic}">
</site-details-permission>
<site-details-permission category="{{ContentSettingsTypes.NOTIFICATIONS}}"
icon="settings:notifications" id="notifications"
- label="$i18n{siteSettingsNotifications}" site="[[site]]">
+ label="$i18n{siteSettingsNotifications}">
</site-details-permission>
<site-details-permission category="{{ContentSettingsTypes.JAVASCRIPT}}"
icon="settings:code" id="javascript"
- label="$i18n{siteSettingsJavascript}" site="[[site]]">
+ label="$i18n{siteSettingsJavascript}">
</site-details-permission>
<site-details-permission category="{{ContentSettingsTypes.PLUGINS}}"
- icon="cr:extension" id="plugins" label="$i18n{siteSettingsFlash}"
- site="[[site]]">
+ icon="cr:extension" id="plugins" label="$i18n{siteSettingsFlash}">
</site-details-permission>
<site-details-permission category="{{ContentSettingsTypes.IMAGES}}"
- icon="settings:photo" id="images" label="$i18n{siteSettingsImages}"
- site="[[site]]">
+ icon="settings:photo" id="images" label="$i18n{siteSettingsImages}">
</site-details-permission>
<site-details-permission category="{{ContentSettingsTypes.POPUPS}}"
- icon="cr:open-in-new" id="popups" label="$i18n{siteSettingsPopups}"
- site="[[site]]">
+ icon="cr:open-in-new" id="popups" label="$i18n{siteSettingsPopups}">
</site-details-permission>
<site-details-permission
category="{{ContentSettingsTypes.BACKGROUND_SYNC}}"
icon="settings:sync" id="backgroundSync"
- label="$i18n{siteSettingsBackgroundSync}" site="[[site]]">
+ label="$i18n{siteSettingsBackgroundSync}">
</site-details-permission>
<site-details-permission
category="{{ContentSettingsTypes.AUTOMATIC_DOWNLOADS}}"
icon="cr:file-download" id="automaticDownloads"
- label="$i18n{siteSettingsAutomaticDownloads}" site="[[site]]">
+ label="$i18n{siteSettingsAutomaticDownloads}">
</site-details-permission>
<site-details-permission
category="{{ContentSettingsTypes.UNSANDBOXED_PLUGINS}}"
icon="cr:extension" id="unsandboxedPlugins"
- label="$i18n{siteSettingsUnsandboxedPlugins}" site="[[site]]">
+ label="$i18n{siteSettingsUnsandboxedPlugins}">
</site-details-permission>
<div class="list-item">
« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/site_details.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698