MD Settings: Set all content setting values in Site Details Javascript.

chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

Index: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
diff --git a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
index 82954acfcc7ec99d64fd35166eb7e55d0a1fc056..c493133c4effc51b35ea2e9b697e3303c7feb528 100644
--- a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
+++ b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
@@ -19,7 +19,7 @@ var ContentSettingProvider = {
 };
 
 /**
- * The site exception information passed form the C++ handler.
+ * The site exception information passed from the C++ handler.
  * See also: SiteException.
  * @typedef {{embeddingOrigin: string,
  *            embeddingDisplayName: string,
@@ -130,13 +130,6 @@ cr.define('settings', function() {
     getExceptionList: function(contentType) {},
 
     /**
-     * Gets the exception details for a particular site.
-     * @param {string} site The name of the site.
-     * @return {!Promise<!RawSiteException>}
-     */
-    getSiteDetails: function(site) {},
-
-    /**
      * Resets the category permission for a given origin (expressed as primary
      *    and secondary patterns).
      * @param {string} primaryPattern The origin to change (primary pattern).
@@ -149,6 +142,9 @@ cr.define('settings', function() {
     resetCategoryPermissionForOrigin: function(
         primaryPattern, secondaryPattern, contentType, incognito) {},
 
+    getCategoryPermissionForOrigin: function(

[tsergeant, 2017/06/16 03:11:40]

As discussed in person, Closure is failing because this method needs annotating.

[Patti Lor, 2017/06/20 08:25:54]

Thanks for debugging this Tim! Fixed :D

+        contentType, requestingOrigin, embeddingOrigin) {},
+
     /**
      * Sets the category permission for a given origin (expressed as primary
      *    and secondary patterns).
@@ -319,11 +315,6 @@ cr.define('settings', function() {
     },
 
     /** @override */
-    getSiteDetails: function(site) {
-      return cr.sendWithPromise('getSiteDetails', site);
-    },
-
-    /** @override */
     resetCategoryPermissionForOrigin: function(
         primaryPattern, secondaryPattern, contentType, incognito) {
       chrome.send(
@@ -332,6 +323,14 @@ cr.define('settings', function() {
     },
 
     /** @override */
+    getCategoryPermissionForOrigin: function(
+        contentType, requestingOrigin, embeddingOrigin) {
+      return cr.sendWithPromise(
+          'getCategoryPermissionForOrigin', contentType, requestingOrigin,
+          embeddingOrigin);
+    },
+
+    /** @override */
     setCategoryPermissionForOrigin: function(
         primaryPattern, secondaryPattern, contentType, value, incognito) {
       // TODO(dschuyler): It may be incorrect for JS to send the embeddingOrigin