MD Settings: Set all content setting values in Site Details Javascript.

chrome/test/data/webui/settings/site_details_permission_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-details. */
 suite('SiteDetailsPermission', function() {
   /**
    * A site list element created before each test.
    * @type {SiteDetailsPermission}
    */
@@ skipping 74 matching lines @@
   test('camera category', function() {
     var origin = 'https://www.example.com';
     browserProxy.setPrefs(prefs);
     testElement.category = settings.ContentSettingsTypes.CAMERA;
     testElement.label = 'Camera';
     testElement.site = {
       origin: origin,
       embeddingOrigin: '',
     };
 
-    return browserProxy.whenCalled('getExceptionList')
-        .then(function() {
-          assertFalse(testElement.$.details.hidden);
+    assertFalse(testElement.$.details.hidden);
 
-          var header = testElement.$.details.querySelector('#permissionHeader');
-          assertEquals(
-              'Camera', header.innerText.trim(),
-              'Widget should be labelled correctly');
+    var header = testElement.$.details.querySelector('#permissionHeader');
+    assertEquals(
+        'Camera', header.innerText.trim(),
+        'Widget should be labelled correctly');
 
-          // Flip the permission and validate that prefs stay in sync.
-          return validatePermissionFlipWorks(
-              origin, settings.PermissionValues.ALLOW);
-        })
-        .then(function() {
-          return validatePermissionFlipWorks(
-              origin, settings.PermissionValues.BLOCK);
-        })
-        .then(function() {
-          return validatePermissionFlipWorks(
-              origin, settings.PermissionValues.ALLOW);
-        });
+    // Flip the permission and validate that prefs stay in sync.

[tsergeant, 2017/06/21 01:49:56]

As in old version of the test, you need promises here to ensure that the test
waits for the asynchronous code in validatePermissionFlipWorks() to run.

The validate function isn't re-entrant, either, so you'll need to keep the
linear structure of the old version of the test:

return validatePermissionFlipWorks(...).then(function() {
  return validatePermissionFlipWorks(...);
}).then(function() {
  return validatePermissionFlipWorks(...);
})

[Patti Lor, 2017/06/21 06:36:37]

Thanks Tim! Fixed.

+    validatePermissionFlipWorks(origin, settings.PermissionValues.ALLOW);
+    validatePermissionFlipWorks(origin, settings.PermissionValues.BLOCK);
+    validatePermissionFlipWorks(origin, settings.PermissionValues.ALLOW);
   });
 
   test('cookies category', function() {
     var origin = 'https://www.example.com';
     browserProxy.setPrefs(prefsCookies);
     testElement.category = settings.ContentSettingsTypes.COOKIES;
     testElement.label = 'Cookies';
     testElement.site = {
       origin: origin,
       embeddingOrigin: '',
     };
 
-    return browserProxy.whenCalled('getExceptionList')
-        .then(function() {
-          assertFalse(testElement.$.details.hidden);
+    assertFalse(testElement.$.details.hidden);
 
-          var header = testElement.$.details.querySelector('#permissionHeader');
-          assertEquals(
-              'Cookies', header.innerText.trim(),
-              'Widget should be labelled correctly');
+    var header = testElement.$.details.querySelector('#permissionHeader');
+    assertEquals(
+        'Cookies', header.innerText.trim(),
+        'Widget should be labelled correctly');
 
-          return validatePermissionFlipWorks(
-              origin, settings.PermissionValues.SESSION_ONLY);
-        })
-        .then(function() {
-          // Flip the permission and validate that prefs stay in sync.
-          return validatePermissionFlipWorks(
-              origin, settings.PermissionValues.ALLOW);
-        })
-        .then(function() {
-          return validatePermissionFlipWorks(
-              origin, settings.PermissionValues.BLOCK);
-        });
+    // Flip the permission and validate that prefs stay in sync.

[tsergeant, 2017/06/21 01:49:56]

As above, use promises here too.

[Patti Lor, 2017/06/21 06:36:37]

Done.

+    validatePermissionFlipWorks(origin, settings.PermissionValues.SESSION_ONLY);
+    validatePermissionFlipWorks(origin, settings.PermissionValues.ALLOW);
+    validatePermissionFlipWorks(origin, settings.PermissionValues.BLOCK);
   });
 });