MD Settings: Set all content setting values in Site Details Javascript.

chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A helper object used from the "Site Settings" section to
  * interact with the content settings prefs.
  */
 
 /**
  * The handler will send a policy source that is similar, but not exactly the
  * same as a ControlledBy value. If the ContentSettingProvider is omitted it
  * should be treated as 'default'.
  * @enum {string}
  */
 var ContentSettingProvider = {
   EXTENSION: 'extension',
   PREFERENCE: 'preference',
 };
 
 /**
- * The site exception information passed form the C++ handler.
+ * The site exception information passed from the C++ handler.
  * See also: SiteException.
  * @typedef {{embeddingOrigin: string,
  *            embeddingDisplayName: string,
  *            incognito: boolean,
  *            origin: string,
  *            displayName: string,
  *            setting: string,
  *            source: string}}
  */
 var RawSiteException;
@@ skipping 90 matching lines @@
     getDefaultValueForContentType: function(contentType) {},
 
     /**
      * Gets the exceptions (site list) for a particular category.
      * @param {string} contentType The name of the category to query.
      * @return {!Promise<!Array<!RawSiteException>>}
      */
     getExceptionList: function(contentType) {},
 
     /**
-     * Gets the exception details for a particular site.
-     * @param {string} site The name of the site.
-     * @return {!Promise<!RawSiteException>}
-     */
-    getSiteDetails: function(site) {},
-
-    /**
      * Resets the category permission for a given origin (expressed as primary
      *    and secondary patterns).
      * @param {string} primaryPattern The origin to change (primary pattern).
      * @param {string} secondaryPattern The embedding origin to change
      *    (secondary pattern).
      * @param {string} contentType The name of the category to reset.
      * @param {boolean} incognito Whether this applies only to a current
      *     incognito session exception.
      */
     resetCategoryPermissionForOrigin: function(
         primaryPattern, secondaryPattern, contentType, incognito) {},
 
     /**
+     * Gets the category permission for a given origin.

[raymes, 2017/06/19 04:13:12]

nit: It may be worth noting that this will be a different value to what will be
in the exception list for the site since it combines different sources of data
into a single permission value.

[Patti Lor, 2017/06/20 08:25:54]

Done, kind of quoted you verbatim.

+     * @param {string} contentType The name of the category to query.
+     * @param {string} origin The origin to look up the permission for.
+     * @param {string} embeddingOrigin the embedding origin to look up.
+     */
+    getCategoryPermissionForOrigin: function(
+        contentType, origin, embeddingOrigin) {},

[raymes, 2017/06/19 04:13:12]

nit: I think embeddingOrigin isn't needed right now. Maybe we should just leave
it out?

[Patti Lor, 2017/06/20 08:25:54]

Done.

+
+    /**
      * Sets the category permission for a given origin (expressed as primary
      *    and secondary patterns).
      * @param {string} primaryPattern The origin to change (primary pattern).
      * @param {string} secondaryPattern The embedding origin to change
      *    (secondary pattern).
      * @param {string} contentType The name of the category to change.
      * @param {string} value The value to change the permission to.
      * @param {boolean} incognito Whether this rule applies only to the current
      *     incognito session.
      */
@@ skipping 149 matching lines @@
     getDefaultValueForContentType: function(contentType) {
       return cr.sendWithPromise('getDefaultValueForContentType', contentType);
     },
 
     /** @override */
     getExceptionList: function(contentType) {
       return cr.sendWithPromise('getExceptionList', contentType);
     },
 
     /** @override */
-    getSiteDetails: function(site) {
-      return cr.sendWithPromise('getSiteDetails', site);
-    },
-
-    /** @override */
     resetCategoryPermissionForOrigin: function(
         primaryPattern, secondaryPattern, contentType, incognito) {
       chrome.send(
           'resetCategoryPermissionForOrigin',
           [primaryPattern, secondaryPattern, contentType, incognito]);
     },
 
     /** @override */
+    getCategoryPermissionForOrigin: function(
+        contentType, origin, embeddingOrigin) {
+      return cr.sendWithPromise(
+          'getCategoryPermissionForOrigin', contentType, origin,
+          embeddingOrigin);
+    },
+
+    /** @override */
     setCategoryPermissionForOrigin: function(
         primaryPattern, secondaryPattern, contentType, value, incognito) {
       // TODO(dschuyler): It may be incorrect for JS to send the embeddingOrigin
       // pattern. Look into removing this parameter from site_settings_handler.
       // Ignoring the |secondaryPattern| and using '' instead is a quick-fix.
       chrome.send(
           'setCategoryPermissionForOrigin',
           [primaryPattern, '', contentType, value, incognito]);
     },
 
@@ skipping 81 matching lines @@
     removeZoomLevel: function(host) {
       chrome.send('removeZoomLevel', [host]);
     },
   };
 
   return {
     SiteSettingsPrefsBrowserProxy: SiteSettingsPrefsBrowserProxy,
     SiteSettingsPrefsBrowserProxyImpl: SiteSettingsPrefsBrowserProxyImpl,
   };
 });