MD Settings: Set all content setting values in Site Details Javascript.

chrome/browser/resources/settings/site_settings/site_details.html

 <link rel="import" href="chrome://resources/html/polymer.html">
 
 <link rel="import" href="chrome://resources/html/action_link.html">
 <link rel="import" href="chrome://resources/html/action_link_css.html">
 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
 <link rel="import" href="chrome://resources/cr_elements/icons.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
 <link rel="import" href="../route.html">
 <link rel="import" href="../settings_shared_css.html">
 <link rel="import" href="constants.html">
@@ skipping 21 matching lines @@
           $i18n{cancel}
         </paper-button>
         <paper-button class="action-button" on-tap="onClearStorage_">
           $i18n{siteSettingsSiteClearAll}
         </paper-button>
       </div>
     </dialog>
 
     <div class="settings-box first">
       <div class="favicon-image"
-          style$="[[computeSiteIcon(site.origin)]]">
+          style$="[[computeSiteIcon(origin)]]">
       </div>
-      <div class="middle">[[site.displayName]]</div>
+      <!-- TODO(patricialor): This should show the origin's display name. -->

[dschuyler, 2017/06/26 22:07:05]

The CL at https://codereview.chromium.org/2919853002/
explores changing how the displayName is generated. I'm mentioning it as an FYI
and to invite you to make a new CL that does something similar (and I'll delete
my CL) or maybe I can help follow-up on this TODO by porting that CL to this new
code.

[Patti Lor, 2017/06/28 09:12:52]

Thank you for the FYI! I think your CL doesn't conflict with this one very much,
since Site Details won't be supporting permissions set on embedded origins in
the near future (it will depend on what "All Sites" ends up looking like), so I
think whoever's CL lands last can just rebase.

The |displayName| on the other hand will probably be needed, but I think we
should explore that in a separate change. I'm happy to explore that in a follow
up to this one, and leave this TODO here, but if you have other plans in mind,
let me know.

+      <div class="middle">[[origin]]</div>
     </div>
     <template is="dom-if" if="[[storedData_]]">
       <div id="usage">
         <div class="settings-box first">
           <h2>$i18n{siteSettingsUsage}</h2>
         </div>
         <div class="list-frame">
           <div class="list-item" id="storage">
             <div class="start">[[storedData_]]</div>
             <button is="paper-icon-button-light" class="icon-delete"
                 on-tap="onConfirmClearStorage_"
                 alt="$i18n{siteSettingsDelete}"></button>
           </div>
         </div>
       </div>
     </template>
     <div class="settings-box first">
       <h2>$i18n{siteSettingsPermissions}</h2>
     </div>
     <div class="list-frame">
       <site-details-permission category="{{ContentSettingsTypes.COOKIES}}"
-          icon="settings:cookie" id="cookies" label="$i18n{siteSettingsCookies}"
-          site="[[site]]">
+          icon="settings:cookie" id="cookies"
+          label="$i18n{siteSettingsCookies}">
       </site-details-permission>
       <site-details-permission category="{{ContentSettingsTypes.GEOLOCATION}}"
           icon="settings:location-on" id="geolocation"
-          label="$i18n{siteSettingsLocation}" site="[[site]]">
+          label="$i18n{siteSettingsLocation}">
       </site-details-permission>
       <site-details-permission category="{{ContentSettingsTypes.CAMERA}}"
           icon="settings:videocam" id="camera"
-          label="$i18n{siteSettingsCamera}" site="[[site]]">
+          label="$i18n{siteSettingsCamera}">
       </site-details-permission>
       <site-details-permission category="{{ContentSettingsTypes.MIC}}"
           icon="settings:mic" id="mic"
-          label="$i18n{siteSettingsMic}" site="[[site]]">
+          label="$i18n{siteSettingsMic}">
       </site-details-permission>
       <site-details-permission category="{{ContentSettingsTypes.NOTIFICATIONS}}"
           icon="settings:notifications" id="notifications"
-          label="$i18n{siteSettingsNotifications}" site="[[site]]">
+          label="$i18n{siteSettingsNotifications}">
       </site-details-permission>
       <site-details-permission category="{{ContentSettingsTypes.JAVASCRIPT}}"
           icon="settings:code" id="javascript"
-          label="$i18n{siteSettingsJavascript}" site="[[site]]">
+          label="$i18n{siteSettingsJavascript}">
       </site-details-permission>
       <site-details-permission category="{{ContentSettingsTypes.PLUGINS}}"
-          icon="cr:extension" id="plugins" label="$i18n{siteSettingsFlash}"
-          site="[[site]]">
+          icon="cr:extension" id="plugins" label="$i18n{siteSettingsFlash}">
       </site-details-permission>
       <site-details-permission category="{{ContentSettingsTypes.IMAGES}}"
-          icon="settings:photo" id="images" label="$i18n{siteSettingsImages}"
-          site="[[site]]">
+          icon="settings:photo" id="images" label="$i18n{siteSettingsImages}">
       </site-details-permission>
       <site-details-permission category="{{ContentSettingsTypes.POPUPS}}"
-          icon="cr:open-in-new" id="popups" label="$i18n{siteSettingsPopups}"
-          site="[[site]]">
+          icon="cr:open-in-new" id="popups" label="$i18n{siteSettingsPopups}">
       </site-details-permission>
       <site-details-permission
           category="{{ContentSettingsTypes.BACKGROUND_SYNC}}"
           icon="settings:sync" id="backgroundSync"
-          label="$i18n{siteSettingsBackgroundSync}" site="[[site]]">
+          label="$i18n{siteSettingsBackgroundSync}">
       </site-details-permission>
       <site-details-permission
           category="{{ContentSettingsTypes.AUTOMATIC_DOWNLOADS}}"
           icon="cr:file-download" id="automaticDownloads"
-          label="$i18n{siteSettingsAutomaticDownloads}" site="[[site]]">
+          label="$i18n{siteSettingsAutomaticDownloads}">
       </site-details-permission>
       <site-details-permission
           category="{{ContentSettingsTypes.UNSANDBOXED_PLUGINS}}"
           icon="cr:extension" id="unsandboxedPlugins"
-          label="$i18n{siteSettingsUnsandboxedPlugins}" site="[[site]]">
+          label="$i18n{siteSettingsUnsandboxedPlugins}">
       </site-details-permission>
 
       <div class="list-item">
         <a is="action-link" class="list-button" on-tap="onClearAndReset_" >
           $i18n{siteSettingsClearAndReset}
         </a>
       </div>
     </div>
     <website-usage-private-api id="usageApi"
         website-data-usage="{{storedData_}}"
         website-storage-type="{{storageType_}}">
     </website-usage-private-api>
   </template>
   <script src="site_details.js"></script>
 </dom-module>