Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2698)

Unified Diff: chrome/browser/resource_coordinator/tab_manager_web_contents_data_unittest.cc

Issue 2936003002: [Tab Metrics] Adding the tab loading state to the WebContentsData. (Closed)
Patch Set: Fix style issues, add TODO Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resource_coordinator/tab_manager_web_contents_data.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resource_coordinator/tab_manager_web_contents_data_unittest.cc
diff --git a/chrome/browser/resource_coordinator/tab_manager_web_contents_data_unittest.cc b/chrome/browser/resource_coordinator/tab_manager_web_contents_data_unittest.cc
index f2c6628f3706fe5c57362a9bd918a16e1f9205c8..8d23d7c27673e6c300165bc7c9f06fde069abfad 100644
--- a/chrome/browser/resource_coordinator/tab_manager_web_contents_data_unittest.cc
+++ b/chrome/browser/resource_coordinator/tab_manager_web_contents_data_unittest.cc
@@ -92,6 +92,14 @@ TEST_F(TabManagerWebContentsDataTest, LastInactiveTime) {
EXPECT_EQ(now, tab_data()->LastInactiveTime());
}
+TEST_F(TabManagerWebContentsDataTest, TabLoadingState) {
+ EXPECT_EQ(TAB_IS_NOT_LOADING, tab_data()->tab_loading_state());
+ tab_data()->SetTabLoadingState(TAB_IS_LOADING);
+ EXPECT_EQ(TAB_IS_LOADING, tab_data()->tab_loading_state());
+ tab_data()->SetTabLoadingState(TAB_IS_LOADED);
+ EXPECT_EQ(TAB_IS_LOADED, tab_data()->tab_loading_state());
+}
+
TEST_F(TabManagerWebContentsDataTest, CopyState) {
std::unique_ptr<WebContents> web_contents2;
auto* tab_data2 = CreateWebContentsAndTabData(&web_contents2);
« no previous file with comments | « chrome/browser/resource_coordinator/tab_manager_web_contents_data.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698