Issue 2935993002: Implement metadata on methods and fields.

Issue 2935993002: Implement metadata on methods and fields. (Closed)

Created:
3 years, 6 months ago by ahe

Modified:
3 years, 6 months ago

Reviewers:
Johnni Winther, Paul Berry

CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+136 lines, -70 lines)			Patch
M	pkg/analyzer/lib/src/fasta/ast_builder.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/front_end/lib/src/fasta/fasta_codes_generated.dart	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/kernel/body_builder.dart	View	4 chunks	+54 lines, -20 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/parser/parser.dart	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/source/diet_listener.dart	View	19 chunks	+49 lines, -30 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/source/stack_listener.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/front_end/messages.yaml	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/front_end/test/fasta/kompile.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/front_end/testcases/rasta/issue_000033.dart.direct.expect	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/front_end/tool/fasta_perf.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/tests/vm/vm.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-kernel.status	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	tests/language/language_kernel.status	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	tests/lib/lib.status	View	2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 9 (4 generated)

ahe

This is ready for review, but I expect some additional status file changes as I ...

3 years, 6 months ago (2017-06-13 18:05:46 UTC) #4

ahe

Surprisingly, no new test passes after implementing metadata on fields. Note to self: I'll have ...

3 years, 6 months ago (2017-06-13 19:20:03 UTC) #6

ahe

Surprisingly, no new test passes after implementing metadata on fields. Note to self: I'll have ...

3 years, 6 months ago (2017-06-13 19:20:06 UTC) #7

ahe

3 years, 6 months ago (2017-06-14 06:25:24 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
3c17c44d522746d7d985da74c014664993fda76a (presubmit successful).