Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2935953002: Fix protobuf's Python runtime and imports.

Created:
3 years, 6 months ago by kraynov
Modified:
3 years, 6 months ago
Reviewers:
wychen
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix protobuf's Python runtime and imports. Protobuf-generated stubs could fallback to system-wide protobuf. Also descriptor_pb2.py was generated manually. Now it's fixed. BUG=732823

Patch Set 1 #

Patch Set 2 : debug import path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1847 lines) Patch
M third_party/dom_distiller_js/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/dom_distiller_js/protoc_plugins/util/plugin_protos.py View 1 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/protobuf/BUILD.gn View 4 chunks +32 lines, -26 lines 0 comments Download
M third_party/protobuf/README.chromium View 1 chunk +1 line, -11 lines 0 comments Download
M third_party/protobuf/proto_library.gni View 1 chunk +1 line, -1 line 0 comments Download
D third_party/protobuf/python/google/protobuf/descriptor_pb2.py View 1 chunk +0 lines, -1797 lines 0 comments Download
M tools/protoc_wrapper/protoc_wrapper.py View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (10 generated)
wychen
3 years, 6 months ago (2017-06-14 03:35:00 UTC) #7
I like this approach.

Powered by Google App Engine
This is Rietveld 408576698