Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2935933005: fix mixins with factory constructors (Closed)

Created:
3 years, 6 months ago by Jennifer Messerly
Modified:
3 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : d #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 2 chunks +4 lines, -1 line 0 comments Download
A tests/language_strong/mixin_factory_constructor_test.dart View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
3 years, 6 months ago (2017-06-13 20:01:13 UTC) #2
vsm
lgtm
3 years, 6 months ago (2017-06-13 20:36:47 UTC) #3
Jennifer Messerly
3 years, 6 months ago (2017-06-13 22:59:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
1f50f0d126ca57bcc9b1a6fd82f039c7418e3df2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698