Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: chrome/browser/chrome_browser_main_extra_parts_exo.h

Issue 2935893004: Add unittest for ArcNotificationContentView (Closed)
Patch Set: Rebased Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main_extra_parts_exo.h
diff --git a/chrome/browser/chrome_browser_main_extra_parts_exo.h b/chrome/browser/chrome_browser_main_extra_parts_exo.h
index 7e97f85d8065ee5cf2901ad29a625265c223c8da..0113c7713780470b6f7adc8583a5a6b2799aadb3 100644
--- a/chrome/browser/chrome_browser_main_extra_parts_exo.h
+++ b/chrome/browser/chrome_browser_main_extra_parts_exo.h
@@ -19,7 +19,7 @@ class Server;
}
namespace arc {
-class ArcNotificationSurfaceManager;
+class ArcNotificationSurfaceManagerImpl;
}
class ChromeBrowserMainExtraPartsExo : public ChromeBrowserMainExtraParts {
@@ -32,7 +32,7 @@ class ChromeBrowserMainExtraPartsExo : public ChromeBrowserMainExtraParts {
void PostMainMessageLoopRun() override;
private:
- std::unique_ptr<arc::ArcNotificationSurfaceManager>
+ std::unique_ptr<arc::ArcNotificationSurfaceManagerImpl>
hidehiko 2017/06/15 15:26:20 nit: unique_ptr<NotificationSurfaceManager> instea
yoshiki 2017/06/16 11:29:08 It's impossible. The dtor of NotificationSurfaceMa
arc_notification_surface_manager_;
std::unique_ptr<exo::WMHelper> wm_helper_;
std::unique_ptr<exo::Display> display_;

Powered by Google App Engine
This is Rietveld 408576698