Add unittest for ArcNotificationContentView

ui/arc/notification/arc_notification_content_view.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_ARC_NOTIFICATION_ARC_NOTIFICATION_CONTENT_VIEW_H_
 #define UI_ARC_NOTIFICATION_ARC_NOTIFICATION_CONTENT_VIEW_H_
 
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
 #include "ui/arc/notification/arc_notification_content_view_delegate.h"
 #include "ui/arc/notification/arc_notification_item.h"
 #include "ui/arc/notification/arc_notification_surface_manager.h"
 #include "ui/aura/window_observer.h"
 #include "ui/gfx/animation/animation_delegate.h"
 #include "ui/message_center/views/padded_button.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/native/native_view_host.h"
 
-namespace exo {
-class NotificationSurface;
-}
-
 namespace gfx {
 class LinearAnimation;
 }
 
 namespace ui {
 struct AXActionData;
 }
 
 namespace views {
 class FocusTraversable;
 class Widget;
 }
 
 namespace arc {
 
+class ArcNotificationSurface;
+
 // ArcNotificationContentView is a view to host NotificationSurface and show the
 // content in itself. This is implemented as a child of ArcNotificationView.
 class ArcNotificationContentView
     : public views::NativeViewHost,
       public views::ButtonListener,
       public aura::WindowObserver,
       public ArcNotificationItem::Observer,
       public ArcNotificationSurfaceManager::Observer,
       public gfx::AnimationDelegate {
  public:
+  static const char kViewClassName[];
+
   explicit ArcNotificationContentView(ArcNotificationItem* item);
   ~ArcNotificationContentView() override;
 
+  // views::View overrides:
+  const char* GetClassName() const override;
+
   std::unique_ptr<ArcNotificationContentViewDelegate>
   CreateContentViewDelegate();
 
  private:
+  friend class ArcNotificationContentViewTest;
+
   class ContentViewDelegate;
   class EventForwarder;
   class SettingsButton;
   class SlideHelper;
 
   // A image button class used for the settings button and the close button.
   // We can't use forward declaration for this class due to std::unique_ptr<>
   // requires size of this class.
   class ControlButton : public message_center::PaddedButton {
    public:
     explicit ControlButton(ArcNotificationContentView* owner);
     void OnFocus() override;
     void OnBlur() override;
 
    private:
     ArcNotificationContentView* const owner_;
 
     DISALLOW_COPY_AND_ASSIGN(ControlButton);
   };
 
+  ArcNotificationSurfaceManager* GetSurfaceManager() const;

[hidehiko, 2017/06/15 15:26:20]

nit: please move this into anonymous namespace in .cc

[yoshiki, 2017/06/16 11:29:08]

I completely removed this method.

   void CreateCloseButton();
   void CreateSettingsButton();
   void MaybeCreateFloatingControlButtons();
-  void SetSurface(exo::NotificationSurface* surface);
+  void SetSurface(ArcNotificationSurface* surface);
   void UpdatePreferredSize();
   void UpdateControlButtonsVisibility();
   void UpdatePinnedState();
   void UpdateSnapshot();
   void AttachSurface();
   void ActivateToast();
   void StartControlButtonsColorAnimation();
   bool ShouldUpdateControlButtonsColor() const;
   void UpdateAccessibleName();
 
@@ skipping 17 matching lines @@
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
                              const gfx::Rect& new_bounds) override;
   void OnWindowDestroying(aura::Window* window) override;
 
   // ArcNotificationItem::Observer
   void OnItemDestroying() override;
   void OnItemUpdated() override;
 
   // ArcNotificationSurfaceManager::Observer:
-  void OnNotificationSurfaceAdded(exo::NotificationSurface* surface) override;
-  void OnNotificationSurfaceRemoved(exo::NotificationSurface* surface) override;
+  void OnNotificationSurfaceAdded(ArcNotificationSurface* surface) override;
+  void OnNotificationSurfaceRemoved(ArcNotificationSurface* surface) override;
 
   // AnimationDelegate
   void AnimationEnded(const gfx::Animation* animation) override;
   void AnimationProgressed(const gfx::Animation* animation) override;
 
   // If |item_| is null, we may be about to be destroyed. In this case,
   // we have to be careful about what we do.
   ArcNotificationItem* item_ = nullptr;
-  exo::NotificationSurface* surface_ = nullptr;
+  ArcNotificationSurface* surface_ = nullptr;
 
   const std::string notification_key_;
 
   // A pre-target event handler to forward events on the surface to this view.
   // Using a pre-target event handler instead of a target handler on the surface
   // window because it has descendant aura::Window and the events on them need
   // to be handled as well.
   // TODO(xiyuan): Revisit after exo::Surface no longer has an aura::Window.
   std::unique_ptr<EventForwarder> event_forwarder_;
 
@@ skipping 17 matching lines @@
   std::unique_ptr<gfx::LinearAnimation> control_button_color_animation_;
 
   base::string16 accessible_name_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcNotificationContentView);
 };
 
 }  // namespace arc
 
 #endif  // UI_ARC_NOTIFICATION_ARC_NOTIFICATION_CONTENT_VIEW_H_