Add unittest for ArcNotificationContentView

components/exo/surface.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/exo/surface.h"
 
 #include <utility>
 
 #include "base/callback_helpers.h"
 #include "base/logging.h"
@@ skipping 164 matching lines @@
                                          &local_point);
     return surface->HitTestRect(gfx::Rect(local_point, gfx::Size(1, 1)));
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CustomWindowTargeter);
 };
 
 }  // namespace
 
+// static
+const char Surface::kSurfaceWindowName[] = "ExoSurface";
+
 ////////////////////////////////////////////////////////////////////////////////
 // Surface, public:
 
 Surface::Surface() : window_(new aura::Window(new CustomWindowDelegate(this))) {
   window_->SetType(aura::client::WINDOW_TYPE_CONTROL);
-  window_->SetName("ExoSurface");
+  window_->SetName(kSurfaceWindowName);

[reveman, 2017/06/21 15:16:36]

We're going to remove |window_| soon to support MUS. Is there some other way we
can solve this? Can you add something to the NotificationSurface class?

[yoshiki, 2017/06/21 16:13:12]

Although I'm not sure how you remove |window_|, the window name
(kSurfaceWindowName) is just for DCHECK to ensure the window hierarchy. So, we
can safely just remove this when you remove |window_|.

[reveman, 2017/06/21 16:22:24]

Each surface will no longer have a window. Only the top-level delegate (e.g.
ShellSurface) will have a window. If the notification code rely on this window
then we need to start looking at how to avoid that asap.

If it's only for a DCHECK that we need to remove soon then I prefer not making
kSurfaceWindowName public.

   window_->SetProperty(kSurfaceKey, this);
   window_->Init(ui::LAYER_SOLID_COLOR);
   window_->SetEventTargeter(base::WrapUnique(new CustomWindowTargeter));
   window_->set_owned_by_parent(false);
   window_->AddObserver(this);
   aura::Env::GetInstance()->context_factory()->AddObserver(this);
   compositor_frame_sink_holder_ = base::MakeUnique<CompositorFrameSinkHolder>(
       this, window_->CreateCompositorFrameSink());
 }
 
@@ skipping 685 matching lines @@
         render_pass->CreateAndAppendDrawQuad<cc::SolidColorDrawQuad>();
     solid_quad->SetNew(quad_state, quad_rect, quad_rect, SK_ColorBLACK, false);
   }
 
   frame.render_pass_list.push_back(std::move(render_pass));
   compositor_frame_sink_holder_->GetCompositorFrameSink()
       ->SubmitCompositorFrame(std::move(frame));
 }
 
 }  // namespace exo