runtime/observatory/tests/service/get_native_allocation_samples_test.dart - Issue 2935873002: Revert "Address additional analysis issues in the observatory codebase."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/get_native_allocation_samples_test.dart

Issue 2935873002: Revert "Address additional analysis issues in the observatory codebase." (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/service/evaluate_with_scope_test.dart ('k') | runtime/observatory/tests/service/service_test_common.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/get_native_allocation_samples_test.dart

diff --git a/runtime/observatory/tests/service/get_native_allocation_samples_test.dart b/runtime/observatory/tests/service/get_native_allocation_samples_test.dart

index 10128021ecbcfb004b70e149a6f11e97439b5614..f818aa8bda885ab2123af24b756fe1890fa671fd 100644

--- a/runtime/observatory/tests/service/get_native_allocation_samples_test.dart

+++ b/runtime/observatory/tests/service/get_native_allocation_samples_test.dart

@@ -3,11 +3,12 @@

// BSD-style license that can be found in the LICENSE file.

// VMOptions=--error_on_bad_type --error_on_bad_override

-import 'package:observatory/cpu_profile.dart';

+import 'dart:developer';

import 'package:observatory/models.dart' as M;

import 'package:observatory/service_io.dart';

+import 'package:observatory/cpu_profile.dart';

import 'package:unittest/unittest.dart';

+import 'service_test_common.dart';

import 'test_helper.dart';

void verifyHelper(var root, bool exclusive) {