Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: runtime/observatory/tests/service/async_step_out_test.dart

Issue 2935873002: Revert "Address additional analysis issues in the observatory codebase." (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/async_step_out_test.dart
diff --git a/runtime/observatory/tests/service/async_step_out_test.dart b/runtime/observatory/tests/service/async_step_out_test.dart
index 5c432c96e911bef6b0203b178960387c6b7ac5ac..8c6718c991feb29c9844b61c0c93294558188bec 100644
--- a/runtime/observatory/tests/service/async_step_out_test.dart
+++ b/runtime/observatory/tests/service/async_step_out_test.dart
@@ -4,11 +4,18 @@
// VMOptions=--error_on_bad_type --error_on_bad_override --verbose_debug --async_debugger
import 'dart:developer';
-import 'dart:io';
-
+import 'package:observatory/models.dart' as M;
+import 'package:observatory/service_io.dart';
+import 'package:unittest/unittest.dart';
import 'service_test_common.dart';
import 'test_helper.dart';
+const LINE_A = 20;
+const LINE_B = 21;
+const LINE_C = 26;
+const LINE_D = 27;
+const LINE_E = 28;
+
helper() async {
print('helper'); // LINE_A.
print('foobar'); // LINE_B.
@@ -21,23 +28,21 @@ testMain() async {
print('z'); // LINE_E.
}
-final ScriptLineParser lineParser = new ScriptLineParser(Platform.script);
-
var tests = [
hasStoppedAtBreakpoint,
- stoppedAtLine(lineParser.lineFor('LINE_C')),
+ stoppedAtLine(LINE_C),
stepOver, // print.
hasStoppedAtBreakpoint,
- stoppedAtLine(lineParser.lineFor('LINE_D')),
+ stoppedAtLine(LINE_D),
stepInto,
hasStoppedAtBreakpoint,
- stoppedAtLine(lineParser.lineFor('LINE_A')),
+ stoppedAtLine(LINE_A),
stepOver, // print.
hasStoppedAtBreakpoint,
- stoppedAtLine(lineParser.lineFor('LINE_B')),
+ stoppedAtLine(LINE_B),
stepOut, // out of helper to awaiter testMain.
hasStoppedAtBreakpoint,
- stoppedAtLine(lineParser.lineFor('LINE_E')),
+ stoppedAtLine(LINE_E),
];
main(args) => runIsolateTests(args, tests, testeeConcurrent: testMain);

Powered by Google App Engine
This is Rietveld 408576698