Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2935813002: "Find" scrolling should be smoothly animated. (Closed)
Patch Set: Move smooth scroll logic to LayoutBox Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 570 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 int PixelSnappedScrollWidth() const; 581 int PixelSnappedScrollWidth() const;
582 int PixelSnappedScrollHeight() const; 582 int PixelSnappedScrollHeight() const;
583 virtual void SetScrollLeft(LayoutUnit); 583 virtual void SetScrollLeft(LayoutUnit);
584 virtual void SetScrollTop(LayoutUnit); 584 virtual void SetScrollTop(LayoutUnit);
585 585
586 void ScrollToPosition(const FloatPoint&, 586 void ScrollToPosition(const FloatPoint&,
587 ScrollBehavior = kScrollBehaviorInstant); 587 ScrollBehavior = kScrollBehaviorInstant);
588 void ScrollByRecursively(const ScrollOffset& delta); 588 void ScrollByRecursively(const ScrollOffset& delta);
589 // If makeVisibleInVisualViewport is set, the visual viewport will be scrolled 589 // If makeVisibleInVisualViewport is set, the visual viewport will be scrolled
590 // if required to make the rect visible. 590 // if required to make the rect visible.
591 void ScrollRectToVisibleRecursive(const LayoutRect&,
bokan 2017/06/13 17:58:51 This should be private
592 const ScrollAlignment& align_x,
593 const ScrollAlignment& align_y,
594 ScrollType = kProgrammaticScroll,
595 bool make_visible_in_visual_viewport = true,
596 ScrollBehavior = kScrollBehaviorAuto);
597
591 void ScrollRectToVisible(const LayoutRect&, 598 void ScrollRectToVisible(const LayoutRect&,
592 const ScrollAlignment& align_x, 599 const ScrollAlignment& align_x,
593 const ScrollAlignment& align_y, 600 const ScrollAlignment& align_y,
594 ScrollType = kProgrammaticScroll, 601 ScrollType = kProgrammaticScroll,
595 bool make_visible_in_visual_viewport = true, 602 bool make_visible_in_visual_viewport = true,
596 ScrollBehavior = kScrollBehaviorAuto); 603 ScrollBehavior = kScrollBehaviorAuto);
597 604
598 LayoutRectOutsets MarginBoxOutsets() const override { 605 LayoutRectOutsets MarginBoxOutsets() const override {
599 return margin_box_outsets_; 606 return margin_box_outsets_;
600 } 607 }
(...skipping 1155 matching lines...) Expand 10 before | Expand all | Expand 10 after
1756 break_value == EBreakBetween::kLeft || 1763 break_value == EBreakBetween::kLeft ||
1757 break_value == EBreakBetween::kPage || 1764 break_value == EBreakBetween::kPage ||
1758 break_value == EBreakBetween::kRecto || 1765 break_value == EBreakBetween::kRecto ||
1759 break_value == EBreakBetween::kRight || 1766 break_value == EBreakBetween::kRight ||
1760 break_value == EBreakBetween::kVerso; 1767 break_value == EBreakBetween::kVerso;
1761 } 1768 }
1762 1769
1763 } // namespace blink 1770 } // namespace blink
1764 1771
1765 #endif // LayoutBox_h 1772 #endif // LayoutBox_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698