Add type inference for assignments to `super[...]`

Add type inference for assignments to `super[...]`

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5d581919487bbfa17445bcf5c5d270c00da139b4

[Paul Berry, 2017-06-12 20:05:03]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-06-12 20:22:17]

LGTM

https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1898: Token
openCurlyBracket, Token closeCurlyBracket) {
Hm... Why it is curly? I thought it is square.

https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/testcases/inf...
File
pkg/front_end/testcases/inference/infer_assign_to_index_super_upwards.dart.direct.expect
(right):

https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/testcases/inf...
pkg/front_end/testcases/inference/infer_assign_to_index_super_upwards.dart.direct.expect:17:
dynamic v1 = let final dynamic #t1 = "x" in let final dynamic #t2 =
self::getInt() in let final dynamic #t3 = this.{=core::Object::noSuchMethod}(new
core::_InvocationMirror::•("[]=", <dynamic>[0, 3, 3].toList(growable: false),
<dynamic>[this, #t1, #t2].toList(growable: false), true)) in #t2;
It is strange that we have this "noSuchMethod" invocation.

[Paul Berry, 2017-06-12 20:33:08]

https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1898: Token
openCurlyBracket, Token closeCurlyBracket) {
On 2017/06/12 20:22:16, scheglov wrote:
> Hm... Why it is curly? I thought it is square.

Good point; the argument is misnamed.  The bad name is both here and in the base
class, as well as some of the other overrides, so I'll fix them all in a
follow-up CL.

https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/testcases/inf...
File
pkg/front_end/testcases/inference/infer_assign_to_index_super_upwards.dart.direct.expect
(right):

https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/testcases/inf...
pkg/front_end/testcases/inference/infer_assign_to_index_super_upwards.dart.direct.expect:17:
dynamic v1 = let final dynamic #t1 = "x" in let final dynamic #t2 =
self::getInt() in let final dynamic #t3 = this.{=core::Object::noSuchMethod}(new
core::_InvocationMirror::•("[]=", <dynamic>[0, 3, 3].toList(growable: false),
<dynamic>[this, #t1, #t2].toList(growable: false), true)) in #t2;
On 2017/06/12 20:22:16, scheglov wrote:
> It is strange that we have this "noSuchMethod" invocation.

Yeah, that seems like a bug.  Peter, do you know what's going on here?

[Paul Berry, 2017-06-12 20:34:43]

Description was changed from

==========
Add type inference for assignments to `super[...]`
==========

to

==========
Add type inference for assignments to `super[...]`

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5d581919487bbfa17445bcf5c5d270c00da139b4
==========

[Paul Berry, 2017-06-12 20:34:45]

Committed patchset #1 (id:1) manually as
5d581919487bbfa17445bcf5c5d270c00da139b4 (presubmit successful).

[ahe, 2017-06-12 20:34:58]

DBC

https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1898: Token
openCurlyBracket, Token closeCurlyBracket) {
On 2017/06/12 20:22:16, scheglov wrote:
> Hm... Why it is curly? I thought it is square.

Could you add a todo about that for me so I can clean it up in all places. I
suspect this has been copied a lot.

[Paul Berry, 2017-06-12 21:03:23]

On 2017/06/12 20:34:58, ahe wrote:
> DBC
> 
>
https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/lib/src/fasta...
> File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):
> 
>
https://codereview.chromium.org/2935783003/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1898: Token
> openCurlyBracket, Token closeCurlyBracket) {
> On 2017/06/12 20:22:16, scheglov wrote:
> > Hm... Why it is curly? I thought it is square.
> 
> Could you add a todo about that for me so I can clean it up in all places. I
> suspect this has been copied a lot.

Whoops, didn't notice your comment before I had already uploaded:
https://codereview.chromium.org/2935833002/