Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2120)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryAdapterTest.java

Issue 2935783002: Send microsecond resolution timestamps to Java history page so they can be sent back. (Closed)
Patch Set: Updates for twellington@ Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryAdapterTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryAdapterTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryAdapterTest.java
index 5810e5c005d3c5566e806362ab5642ee73ffcc42..78d541285af1688b496df0683ea31f2443b4292c 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryAdapterTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryAdapterTest.java
@@ -58,8 +58,8 @@ public class HistoryAdapterTest {
@SmallTest
public void testInitialize_SingleItem() {
Date today = new Date();
- long[] timestamps = {today.getTime(), today.getTime() - 100};
- HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamps);
+ long timestamp = today.getTime();
+ HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamp);
mHistoryProvider.addItem(item1);
initializeAdapter();
@@ -72,11 +72,11 @@ public class HistoryAdapterTest {
@SmallTest
public void testRemove_TwoItemsOneDate() {
Date today = new Date();
- long[] timestamps = {today.getTime()};
- HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamps);
+ long timestamp = today.getTime();
+ HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamp);
mHistoryProvider.addItem(item1);
- HistoryItem item2 = StubbedHistoryProvider.createHistoryItem(1, timestamps);
+ HistoryItem item2 = StubbedHistoryProvider.createHistoryItem(1, timestamp);
mHistoryProvider.addItem(item2);
initializeAdapter();
@@ -106,12 +106,12 @@ public class HistoryAdapterTest {
@SmallTest
public void testRemove_TwoItemsTwoDates() {
Date today = new Date();
- long[] timestamps = {today.getTime()};
- HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamps);
+ long timestamp = today.getTime();
+ HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamp);
mHistoryProvider.addItem(item1);
- long[] timestamps2 = {today.getTime() - TimeUnit.DAYS.toMillis(3)};
- HistoryItem item2 = StubbedHistoryProvider.createHistoryItem(1, timestamps2);
+ long timestamp2 = today.getTime() - TimeUnit.DAYS.toMillis(3);
+ HistoryItem item2 = StubbedHistoryProvider.createHistoryItem(1, timestamp2);
mHistoryProvider.addItem(item2);
initializeAdapter();
@@ -142,12 +142,12 @@ public class HistoryAdapterTest {
@SmallTest
public void testSearch() {
Date today = new Date();
- long[] timestamps = {today.getTime()};
- HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamps);
+ long timestamp = today.getTime();
+ HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamp);
mHistoryProvider.addItem(item1);
- long[] timestamps2 = {today.getTime() - TimeUnit.DAYS.toMillis(3)};
- HistoryItem item2 = StubbedHistoryProvider.createHistoryItem(1, timestamps2);
+ long timestamp2 = today.getTime() - TimeUnit.DAYS.toMillis(3);
+ HistoryItem item2 = StubbedHistoryProvider.createHistoryItem(1, timestamp2);
mHistoryProvider.addItem(item2);
initializeAdapter();
@@ -168,28 +168,28 @@ public class HistoryAdapterTest {
@SmallTest
public void testLoadMoreItems() {
Date today = new Date();
- long[] timestamps = {today.getTime()};
- HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamps);
+ long timestamp = today.getTime();
+ HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamp);
mHistoryProvider.addItem(item1);
- HistoryItem item2 = StubbedHistoryProvider.createHistoryItem(1, timestamps);
+ HistoryItem item2 = StubbedHistoryProvider.createHistoryItem(1, timestamp);
mHistoryProvider.addItem(item2);
- HistoryItem item3 = StubbedHistoryProvider.createHistoryItem(2, timestamps);
+ HistoryItem item3 = StubbedHistoryProvider.createHistoryItem(2, timestamp);
mHistoryProvider.addItem(item3);
- HistoryItem item4 = StubbedHistoryProvider.createHistoryItem(3, timestamps);
+ HistoryItem item4 = StubbedHistoryProvider.createHistoryItem(3, timestamp);
mHistoryProvider.addItem(item4);
- long[] timestamps2 = {today.getTime() - TimeUnit.DAYS.toMillis(2)};
- HistoryItem item5 = StubbedHistoryProvider.createHistoryItem(4, timestamps2);
+ long timestamp2 = today.getTime() - TimeUnit.DAYS.toMillis(2);
+ HistoryItem item5 = StubbedHistoryProvider.createHistoryItem(4, timestamp2);
mHistoryProvider.addItem(item5);
- HistoryItem item6 = StubbedHistoryProvider.createHistoryItem(0, timestamps2);
+ HistoryItem item6 = StubbedHistoryProvider.createHistoryItem(0, timestamp2);
mHistoryProvider.addItem(item6);
- long[] timestamps3 = {today.getTime() - TimeUnit.DAYS.toMillis(4)};
- HistoryItem item7 = StubbedHistoryProvider.createHistoryItem(1, timestamps3);
+ long timestamp3 = today.getTime() - TimeUnit.DAYS.toMillis(4);
+ HistoryItem item7 = StubbedHistoryProvider.createHistoryItem(1, timestamp3);
mHistoryProvider.addItem(item7);
initializeAdapter();
@@ -210,8 +210,8 @@ public class HistoryAdapterTest {
@SmallTest
public void testOnHistoryDeleted() throws Exception {
Date today = new Date();
- long[] timestamps = {today.getTime()};
- HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamps);
+ long timestamp = today.getTime();
+ HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamp);
mHistoryProvider.addItem(item1);
initializeAdapter();
@@ -234,11 +234,11 @@ public class HistoryAdapterTest {
@SmallTest
public void testBlockedSite() {
Date today = new Date();
- long[] timestamps = {today.getTime()};
- HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamps);
+ long timestamp = today.getTime();
+ HistoryItem item1 = StubbedHistoryProvider.createHistoryItem(0, timestamp);
mHistoryProvider.addItem(item1);
- HistoryItem item2 = StubbedHistoryProvider.createHistoryItem(5, timestamps);
+ HistoryItem item2 = StubbedHistoryProvider.createHistoryItem(5, timestamp);
mHistoryProvider.addItem(item2);
initializeAdapter();

Powered by Google App Engine
This is Rietveld 408576698