Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2935763004: Implement type inference for "not" expressions. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-12 22:14:08 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2935763004/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right): https://codereview.chromium.org/2935763004/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart#newcode1313 pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:1313: operand, inferrer.coreTypes.boolClass.rawType, false); Maybe extract boolType into a ...
3 years, 6 months ago (2017-06-12 23:29:29 UTC) #3
Paul Berry
https://codereview.chromium.org/2935763004/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart File pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart (right): https://codereview.chromium.org/2935763004/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart#newcode1313 pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart:1313: operand, inferrer.coreTypes.boolClass.rawType, false); On 2017/06/12 23:29:28, scheglov wrote: > ...
3 years, 6 months ago (2017-06-13 00:39:54 UTC) #4
Paul Berry
3 years, 6 months ago (2017-06-13 00:44:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
24bb748bc72eac730e7d58e8e89a61df5ac4a5ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698