Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2935733003: Remove some unnecessary tests for non-driver mode (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -53 lines) Patch
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +4 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 2 chunks +2 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 4 chunks +5 lines, -22 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/stress/utilities/server.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-12 17:36:23 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-12 18:29:19 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-12 18:31:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
65d05524cefb424b799757dfeb5ac4fa4521b987 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698