Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: ios/chrome/browser/ui/util/manual_text_framer_unittest.mm

Issue 2935723002: Fix ManualTextFramerTest.OriginRTLTest on iOS 11 (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/ios/ios_util.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/util/manual_text_framer_unittest.mm
diff --git a/ios/chrome/browser/ui/util/manual_text_framer_unittest.mm b/ios/chrome/browser/ui/util/manual_text_framer_unittest.mm
index 2b4e0e27d06e969da7f4b5d8aa92d76935974789..444b6aba110d995a0dcc9595d6ff3669d7b8425a 100644
--- a/ios/chrome/browser/ui/util/manual_text_framer_unittest.mm
+++ b/ios/chrome/browser/ui/util/manual_text_framer_unittest.mm
@@ -4,6 +4,7 @@
#include "ios/chrome/browser/ui/util/manual_text_framer.h"
+#include "base/ios/ios_util.h"
#include "base/mac/foundation_util.h"
#include "base/time/time.h"
#import "ios/chrome/browser/ui/util/core_text_util.h"
@@ -198,7 +199,9 @@ TEST_F(ManualTextFramerTest, OriginRTLTest) {
attributes()[NSParagraphStyleAttributeName] = CreateParagraphStyle(
20.0, NSTextAlignmentNatural, NSLineBreakByWordWrapping);
ApplyAttributesForRange(text_range());
- CGRect bounds = CGRectMake(0, 0, 100.0, 60.0);
+ CGRect bounds = base::ios::IsRunningOnIOS11OrLater()
kkhorimoto 2017/06/12 19:42:03 Can we separate the width calculation out and add
lpromero 2017/06/13 08:10:25 Done.
+ ? CGRectMake(0, 0, 130.0, 60.0)
+ : CGRectMake(0, 0, 100.0, 60.0);
FrameTextInBounds(bounds);
CheckForLineCountAndFramedRange(3, text_range());
for (FramedLine* line in text_frame().lines) {
« no previous file with comments | « base/ios/ios_util.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698