pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart - Issue 2935663002: Remove Compiler.commonElements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

Issue 2935663002: Remove Compiler.commonElements (Closed)

Patch Set: Remove Compiler._commonElements Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

index 923d331edf0084a990fa3f3c59ab865e53b58ae4..137c63782d6790664f202aa0580fda3ecec099f1 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

@@ -132,20 +132,20 @@ jsAst.Statement buildSetupProgram(

'enabledJsInterop': backend.nativeBasicData.isJsInteropUsed,

'jsInteropBoostrap': backend.jsInteropAnalysis.buildJsInteropBootstrap(),

'isInterceptorClass':

- namer.operatorIs(compiler.commonElements.jsInterceptorClass),

- 'isObject': namer.operatorIs(compiler.commonElements.objectClass),

+ namer.operatorIs(closedWorld.commonElements.jsInterceptorClass),

+ 'isObject': namer.operatorIs(closedWorld.commonElements.objectClass),

'specProperty': js.string(namer.nativeSpecProperty),

'trivialNsmHandlers': emitter.buildTrivialNsmHandlers(),

'hasRetainedMetadata': backend.mirrorsData.hasRetainedMetadata,

'types': typesAccess,

'objectClassName': js.quoteName(namer.runtimeTypeName(

// ignore: UNNECESSARY_CAST

- compiler.commonElements.objectClass as Entity)),

+ closedWorld.commonElements.objectClass as Entity)),

'needsStructuredMemberInfo': emitter.needsStructuredMemberInfo,

- 'usesMangledNames': compiler.commonElements.mirrorsLibrary != null ||

+ 'usesMangledNames': closedWorld.commonElements.mirrorsLibrary != null ||

closedWorld.backendUsage.isFunctionApplyUsed,

'tearOffCode': buildTearOffCode(

- compiler.options, emitter, namer, compiler.commonElements),

+ compiler.options, emitter, namer, closedWorld.commonElements),

'nativeInfoHandler': nativeInfoHandler,

'operatorIsPrefix': js.string(namer.operatorIsPrefix),

'deferredActionString': js.string(namer.deferredAction)