Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2935663002: Remove Compiler.commonElements (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Remove Compiler._commonElements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -230 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 5 chunks +9 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/list_tracer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/map_tracer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 5 chunks +16 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 2 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 2 chunks +6 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 5 chunks +9 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 4 chunks +10 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/tool/perf.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/expect_annotations_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/jsinterop/world_test.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 2 chunks +10 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/minimal_resolution_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/no_such_method_enabled_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 25 chunks +56 lines, -43 lines 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolution_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_final_field2_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/trust_type_annotations_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 3 chunks +31 lines, -31 lines 0 comments Download
M tests/compiler/dart2js/type_mask_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-13 10:54:24 UTC) #2
Emily Fortuna
lgtm
3 years, 6 months ago (2017-06-13 17:43:18 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-14 08:18:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
5afe65e89174247328d59d39ab99dd5a08116df6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698