Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 293563002: GetScaleFactorForNativeView should return scale factor in float (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index a7f5b0b50e66393f337fa0517e0d1c46a36017fc..846f5b181ac426dbe2b71e54545e4ae08d48f07f 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -149,10 +149,6 @@ static BOOL SupportsBackingPropertiesChangedNotification() {
return methodDescription.name != NULL || methodDescription.types != NULL;
}
-static float ScaleFactorForView(NSView* view) {
- return ui::GetImageScale(ui::GetScaleFactorForNativeView(view));
-}
-
// Private methods:
@interface RenderWidgetHostViewCocoa ()
@property(nonatomic, assign) NSRange selectedRange;
@@ -809,7 +805,7 @@ int RenderWidgetHostViewMac::window_number() const {
}
float RenderWidgetHostViewMac::ViewScaleFactor() const {
- return ScaleFactorForView(cocoa_view_);
+ return ui::GetScaleFactorForNativeView(cocoa_view_);
}
void RenderWidgetHostViewMac::UpdateDisplayLink() {
@@ -847,7 +843,7 @@ void RenderWidgetHostViewMac::UpdateBackingStoreScaleFactor() {
if (!render_widget_host_)
return;
- float new_scale_factor = ScaleFactorForView(cocoa_view_);
+ float new_scale_factor = ui::GetScaleFactorForNativeView(cocoa_view_);
if (new_scale_factor == backing_store_scale_factor_)
return;
backing_store_scale_factor_ = new_scale_factor;
@@ -1251,7 +1247,7 @@ void RenderWidgetHostViewMac::CopyFromCompositingSurface(
}
base::ScopedClosureRunner scoped_callback_runner(
base::Bind(callback, false, SkBitmap()));
- float scale = ScaleFactorForView(cocoa_view_);
+ float scale = ui::GetScaleFactorForNativeView(cocoa_view_);
gfx::Size dst_pixel_size = gfx::ToFlooredSize(
gfx::ScaleSize(dst_size, scale));
if (compositing_iosurface_ && compositing_iosurface_->HasIOSurface()) {
@@ -2499,7 +2495,7 @@ SkBitmap::Config RenderWidgetHostViewMac::PreferredReadbackFormat() {
canBeKeyView_ = YES;
focusedPluginIdentifier_ = -1;
renderWidgetHostView_->backing_store_scale_factor_ =
- ScaleFactorForView(self);
+ ui::GetScaleFactorForNativeView(self);
// OpenGL support:
if ([self respondsToSelector:

Powered by Google App Engine
This is Rietveld 408576698