chrome/browser/ui/views/create_application_shortcut_view.cc - Issue 293563002: GetScaleFactorForNativeView should return scale factor in float

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.cc

Issue 293563002: GetScaleFactorForNativeView should return scale factor in float (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/create_application_shortcut_view.cc

diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc

index a84cc04974f564af88eb0f6d39e77fc964717f10..b0e6e253ab36d93530558fdcc79e16e4c26cd626 100644

--- a/chrome/browser/ui/views/create_application_shortcut_view.cc

+++ b/chrome/browser/ui/views/create_application_shortcut_view.cc

@@ -495,8 +495,9 @@ void CreateUrlApplicationShortcutView::DidDownloadFavicon(

if (!bitmaps.empty()) {

std::vector<ui::ScaleFactor> scale_factors;

- ui::ScaleFactor scale_factor = ui::GetScaleFactorForNativeView(

- web_contents_->GetRenderViewHost()->GetView()->GetNativeView());

+ ui::ScaleFactor scale_factor = ui::GetSupportedScaleFactor(

+ ui::GetScaleFactorForNativeView(

+ web_contents_->GetRenderViewHost()->GetView()->GetNativeView()));

scale_factors.push_back(scale_factor);

std::vector<size_t> closest_indices;

SelectFaviconFrameIndices(original_bitmap_sizes,