pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart - Issue 2935553002: fix checking of dsend generic type bounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

Issue 2935553002: fix checking of dsend generic type bounds (Closed)

Patch Set: merged Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/dev_compiler/test/browser/language_tests.js ('k') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

index ea3ef3a1b8857b872b93738787d6893d271620cd..174bc54670108b14452a5b09d4b337062cfce69a 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

@@ -304,6 +304,8 @@ _checkAndCall(f, ftype, obj, typeArgs, args, name) => JS(

'incorrect number of arguments to generic function ' +

$typeName($ftype) + ', got <' + $typeArgs + '> expected ' +

formalCount + '.');

+ } else {

+ $ftype.checkBounds($typeArgs);

}

$ftype = $ftype.instantiate($typeArgs);

} else if ($typeArgs != null) {

« no previous file with comments | « pkg/dev_compiler/test/browser/language_tests.js ('k') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart » ('j') | no next file with comments »