Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2935503002: List Java Instru Test Information From JUnit Runner (Closed)
Patch Set: compiling error fix Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py
diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
index 34e275d33fd53d0d36e64f5aea9ceb9ffb925a1c..29db4face782fa216453bc157fefb2e17eb5c9b1 100644
--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py
+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
@@ -88,8 +88,8 @@ def _LogTestEndpoints(device, test_name):
['log', '-p', 'i', '-t', _TAG, 'END %s' % test_name],
check_return=True)
-# TODO(jbudorick): Make this private once the instrumentation test_runner is
-# deprecated.
+# TODO(jbudorick): Make this private once the instrumentation test_runner
+# is deprecated.
def DidPackageCrashOnDevice(package_name, device):
# Dismiss any error dialogs. Limit the number in case we have an error
# loop or we are failing to dismiss.
@@ -306,7 +306,8 @@ class LocalDeviceInstrumentationTestRun(
#override
def _GetTests(self):
- tests = self._test_instance.GetTests()
+ device = self._env.devices[0]
+ tests = self._test_instance.GetTests(device)
tests = self._ApplyExternalSharding(
tests, self._test_instance.external_shard_index,
self._test_instance.total_external_shards)
@@ -371,10 +372,11 @@ class LocalDeviceInstrumentationTestRun(
if test['is_junit4']:
target = '%s/%s' % (
self._test_instance.test_package,
- self._test_instance.test_runner_junit4)
+ self._test_instance.junit4_runner_class)
else:
target = '%s/%s' % (
- self._test_instance.test_package, self._test_instance.test_runner)
+ self._test_instance.test_package,
+ self._test_instance.junit3_runner_class)
extras['class'] = test_name
if 'flags' in test and test['flags']:
flags_to_add.extend(test['flags'])

Powered by Google App Engine
This is Rietveld 408576698