List Java Instru Test Information From JUnit Runner

build/android/pylib/instrumentation/instrumentation_test_instance.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import copy
 import json
 import logging
 import os
 import pickle
@@ skipping 29 matching lines @@
     'org.chromium.test.driver.OnDeviceInstrumentationDriver.TestList')
 _EXTRA_DRIVER_TEST_LIST_FILE = (
     'org.chromium.test.driver.OnDeviceInstrumentationDriver.TestListFile')
 _EXTRA_DRIVER_TARGET_PACKAGE = (
     'org.chromium.test.driver.OnDeviceInstrumentationDriver.TargetPackage')
 _EXTRA_DRIVER_TARGET_CLASS = (
     'org.chromium.test.driver.OnDeviceInstrumentationDriver.TargetClass')
 _EXTRA_TIMEOUT_SCALE = (
     'org.chromium.test.driver.OnDeviceInstrumentationDriver.TimeoutScale')
 
+_WEBVIEW_JUNIT4_PARAMETERIZATION = 'WebViewParameterization'
+_WEBVIEW_JUNIT4_SKIP_PARAMETERIZATION = 'SkipWebViewParameterization'
+
 _PARAMETERIZED_TEST_ANNOTATION = 'ParameterizedTest'
 _PARAMETERIZED_TEST_SET_ANNOTATION = 'ParameterizedTest$Set'
 _NATIVE_CRASH_RE = re.compile('(process|native) crash', re.IGNORECASE)
 _CMDLINE_NAME_SEGMENT_RE = re.compile(
     r' with(?:out)? \{[^\}]*\}')
 _PICKLE_FORMAT_VERSION = 11
 
 
 class MissingSizeAnnotationError(test_exception.TestException):
   def __init__(self, class_name):
@@ skipping 169 matching lines @@
     unqualified_class_test = {
       'class': t['class'].split('.')[-1],
       'method': t['method']
     }
     names = [
       GetTestName(t, sep='.'),
       GetTestName(unqualified_class_test, sep='.'),
       GetUniqueTestName(t, sep='.')
     ]
 
+    if t['is_junit4'] and t.get('webview_parameterization'):

[jbudorick, 2017/06/12 13:21:43]

I'm not sure why this is necessary beyond what GetUniqueTestName already does.

+      names += [
+          GetTestNameWithoutParameterPostfix(t, sep='.'),
+          GetTestNameWithoutParameterPostfix(unqualified_class_test, sep='.')
+      ]
+
     pattern_groups = test_filter.split('-')
     if len(pattern_groups) > 1:
       negative_filter = pattern_groups[1]
       if unittest_util.FilterTestNames(names, negative_filter):
         return []
 
     positive_filter = pattern_groups[0]
     return unittest_util.FilterTestNames(names, positive_filter)
 
   def annotation_filter(all_annotations):
@@ skipping 174 matching lines @@
 
   Args:
     test: the instrumentation test dict.
     sep: the character(s) that should join the class name and the method name.
   Returns:
     The test name as a string.
   """
   return '%s%s%s' % (test['class'], sep, test['method'])
 
 
+def GetTestNameWithoutParameterPostfix(
+      test, sep='#', parameter_postfix='__'):
+  """Gets the name of the given JUnit4 test withouth parameter postfix.
+
+  For most WebView JUnit4 javatests, each test is parameterizatized with
+  "__sandboxed_mode" to run in both non-sandboxed mode and sandboxed mode.
+
+  This function returns the name of the test without parameterization
+  so test filters can match both parameterized and non-parameterized tests.
+
+  Args:
+    test: the instrumentation test dict.
+    sep: the character(s) that should join the class name and the method name.
+    parameterization_sep: the character(s) that seperate method name and method
+                          parameterization postfix.
+  Returns:
+    The test name without parameter postfix as a string.
+  """
+  name = GetTestName(test, sep=sep)
+  return name.split(parameter_postfix)[0]
+
+
 def GetUniqueTestName(test, sep='#'):
   """Gets the unique name of the given test.
 
   This will include text to disambiguate between tests for which GetTestName
   would return the same name.
 
   Args:
     test: the instrumentation test dict.
     sep: the character(s) that should join the class name and the method name.
   Returns:
@@ skipping 409 matching lines @@
             'class': c['class'],
             'method': m['method'],
             'annotations': a,
             'is_junit4': c['superclass'] == 'java.lang.Object'
         })
     return inflated_tests
 
   def _ParametrizeTestsWithFlags(self, tests):
     new_tests = []
     for t in tests:
-      parameters = ParseCommandLineFlagParameters(t['annotations'])
-      if parameters:
-        t['flags'] = parameters[0]
-        for p in parameters[1:]:
-          parameterized_t = copy.copy(t)
-          parameterized_t['flags'] = p
-          new_tests.append(parameterized_t)
+      if (_WEBVIEW_JUNIT4_PARAMETERIZATION in t['annotations']

[jbudorick, 2017/06/12 13:21:43]

This is too webview-specific. Let's talk about generalizing it.

+          and _WEBVIEW_JUNIT4_SKIP_PARAMETERIZATION not in t['annotations']
+          and t['is_junit4']):
+        parameterized_t = copy.copy(t)
+        parameterized_t['webview_parameterization'] = True
+        parameterized_t['method'] += '__sandboxed_mode'
+        new_tests.append(parameterized_t)
+      else:
+        parameters = ParseCommandLineFlagParameters(t['annotations'])
+        if parameters:
+          t['flags'] = parameters[0]
+          for p in parameters[1:]:
+            parameterized_t = copy.copy(t)
+            parameterized_t['flags'] = p
+            new_tests.append(parameterized_t)
     return tests + new_tests
 
   def GetDriverEnvironmentVars(
       self, test_list=None, test_list_file_path=None):
     env = {
       _EXTRA_DRIVER_TARGET_PACKAGE: self.test_package,
       _EXTRA_DRIVER_TARGET_CLASS: self.test_runner,
       _EXTRA_TIMEOUT_SCALE: self._timeout_scale,
     }
 
@@ skipping 12 matching lines @@
 
   @staticmethod
   def GenerateTestResults(
       result_code, result_bundle, statuses, start_ms, duration_ms):
     return GenerateTestResults(result_code, result_bundle, statuses,
                                start_ms, duration_ms)
 
   #override
   def TearDown(self):
     pass