Update Fuchsia-specific code to use the new MX_ error names

runtime/bin/process_fuchsia.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #if !defined(DART_IO_DISABLED)
 
 #include "platform/globals.h"
 #if defined(HOST_OS_FUCHSIA)
 
 #include "bin/process.h"
@@ skipping 320 matching lines @@
   static void HandleInterruptMsg() {
     ASSERT(items_[0].handle == interrupt_out_);
     ASSERT(items_[0].waitfor == MX_SOCKET_READABLE);
     ASSERT((items_[0].pending & MX_SOCKET_READABLE) != 0);
     while (true) {
       Message msg;
       size_t actual = 0;
       LOG_INFO("ExitCodeHandler thread reading interrupt message\n");
       mx_status_t status =
           mx_socket_read(interrupt_out_, 0, &msg, sizeof(msg), &actual);
-      if (status == ERR_SHOULD_WAIT) {
+      if (status == MX_ERR_SHOULD_WAIT) {
         LOG_INFO("ExitCodeHandler thread done reading interrupt messages\n");
         return;
       }
       if (status < 0) {
         FATAL1("Failed to read exit handler interrupt handle: %s\n",
                mx_status_get_string(status));
       }
       if (actual < sizeof(msg)) {
         FATAL1("Short read from exit handler interrupt handle: %ld\n", actual);
       }
@@ skipping 79 matching lines @@
 intptr_t Process::CurrentProcessId() {
   return static_cast<intptr_t>(getpid());
 }
 
 
 int64_t Process::CurrentRSS() {
   mx_info_task_stats_t task_stats;
   mx_handle_t process = mx_process_self();
   mx_status_t status = mx_object_get_info(
       process, MX_INFO_TASK_STATS, &task_stats, sizeof(task_stats), NULL, NULL);
-  if (status != NO_ERROR) {
+  if (status != MX_OK) {
     // TODO(zra): Translate this to a Unix errno.
     errno = status;
     return -1;
   }
   return task_stats.mem_private_bytes + task_stats.mem_shared_bytes;
 }
 
 
 int64_t Process::MaxRSS() {
   // There is currently no way to get the high watermark value on Fuchsia, so
@@ skipping 153 matching lines @@
   }
   // We can only use mx_task_kill if we know id is a process handle, and we only
   // know that for sure if it's in our list.
   mx_handle_t process = static_cast<mx_handle_t>(id);
   if (!ProcessInfoList::Exists(process)) {
     LOG_ERR("Process %ld wasn't in the ProcessInfoList\n", id);
     errno = ESRCH;  // No such process.
     return false;
   }
   mx_status_t status = mx_task_kill(process);
-  if (status != NO_ERROR) {
+  if (status != MX_OK) {
     LOG_ERR("mx_task_kill failed: %s\n", mx_status_get_string(status));
     errno = EPERM;  // TODO(zra): Figure out what it really should be.
     return false;
   }
   LOG_INFO("Signal %d sent successfully to process %ld\n", signal, id);
   return true;
 }
 
 
 class ProcessStarter {
@@ skipping 67 matching lines @@
       *os_error_message_ = DartUtils::ScopedCopyCString(
           "Failed to create exit code pipe for process start.");
       return result;
     }
     LOG_INFO("ProcessStarter: Start() set up exit_pipe_fds (%d, %d)\n",
              exit_pipe_fds[0], exit_pipe_fds[1]);
 
     // Set up a launchpad.
     launchpad_t* lp = NULL;
     mx_status_t status = SetupLaunchpad(&lp);
-    if (status != NO_ERROR) {
+    if (status != MX_OK) {
       close(exit_pipe_fds[0]);
       close(exit_pipe_fds[1]);
       return status;
     }
     ASSERT(lp != NULL);
 
     // Launch it.
     LOG_INFO("ProcessStarter: Start() Calling launchpad_start\n");
     mx_handle_t process = MX_HANDLE_INVALID;
     const char* errormsg = NULL;
@@ skipping 45 matching lines @@
 
   mx_status_t SetupLaunchpad(launchpad_t** launchpad) {
     // Set up a vmo for the binary.
     mx_handle_t binary_vmo = launchpad_vmo_from_file(path_);
     CHECK_FOR_ERROR(binary_vmo, "launchpad_vmo_from_file");
 
     // Run the child process in the same "job".
     mx_handle_t job = MX_HANDLE_INVALID;
     mx_status_t status =
         mx_handle_duplicate(mx_job_default(), MX_RIGHT_SAME_RIGHTS, &job);
-    if (status != NO_ERROR) {
+    if (status != MX_OK) {
       mx_handle_close(binary_vmo);
     }
     CHECK_FOR_ERROR(status, "mx_handle_duplicate");
 
     // Set up the launchpad.
     launchpad_t* lp = NULL;
     launchpad_create(job, program_arguments_[0], &lp);
     launchpad_set_args(lp, program_arguments_count_, program_arguments_);
     launchpad_set_environ(lp, program_environment_);
     launchpad_clone(lp, LP_CLONE_MXIO_ROOT);
     // TODO(zra): Use the supplied working directory when launchpad adds an
     // API to set it.
     launchpad_clone(lp, LP_CLONE_MXIO_CWD);
     launchpad_add_pipe(lp, &write_out_, 0);
     launchpad_add_pipe(lp, &read_in_, 1);
     launchpad_add_pipe(lp, &read_err_, 2);
     launchpad_add_vdso_vmo(lp);
     launchpad_elf_load(lp, binary_vmo);
     launchpad_load_vdso(lp, MX_HANDLE_INVALID);
     *launchpad = lp;
-    return NO_ERROR;
+    return MX_OK;
   }
 
 #undef CHECK_FOR_ERROR
 
   int read_in_;    // Pipe for stdout to child process.
   int read_err_;   // Pipe for stderr to child process.
   int write_out_;  // Pipe for stdin to child process.
 
   char** program_arguments_;
   intptr_t program_arguments_count_;
@@ skipping 44 matching lines @@
 }
 
 void Process::ClearSignalHandler(intptr_t signal) {}
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(HOST_OS_FUCHSIA)
 
 #endif  // !defined(DART_IO_DISABLED)