Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2935483002: Update Fuchsia-specific code to use the new MX_ error names (Closed)

Created:
3 years, 6 months ago by kulakowski1
Modified:
3 years, 6 months ago
Reviewers:
zra, kulakowski
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update Fuchsia-specific code to use the new MX_ error names R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/a834e6dcf3fb70b0fdcc5d752795592a3fd987be

Patch Set 1 #

Total comments: 3

Patch Set 2 : not windows tho #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M runtime/bin/crypto_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_fuchsia.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_thread_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread_interrupter_fuchsia.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/virtual_memory_fuchsia.cc View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kulakowski
3 years, 6 months ago (2017-06-09 16:55:37 UTC) #2
zra
https://codereview.chromium.org/2935483002/diff/1/runtime/bin/eventhandler_win.cc File runtime/bin/eventhandler_win.cc (right): https://codereview.chromium.org/2935483002/diff/1/runtime/bin/eventhandler_win.cc#newcode542 runtime/bin/eventhandler_win.cc:542: if (rc == MX_OK) { This is a Windows ...
3 years, 6 months ago (2017-06-09 19:24:25 UTC) #3
kulakowski1
It's almost like that's why we're doing this! Thanks.
3 years, 6 months ago (2017-06-09 19:59:08 UTC) #4
zra
lgtm
3 years, 6 months ago (2017-06-09 20:18:26 UTC) #5
zra
3 years, 6 months ago (2017-06-09 20:19:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a834e6dcf3fb70b0fdcc5d752795592a3fd987be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698