Add UMA for Cras stream timeout.

Add UMA for Cras stream timeout.

BUG=327817
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272251

[hychao, 2014-05-21 04:08:42]

Hi Alexei,
This change is to add a histogram for CRAS (Chrome OS audio server). Please help
take a look, thanks!

[Alexei Svitkine (slow), 2014-05-21 06:04:15]

https://codereview.chromium.org/293543004/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/293543004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:1873: +  <summary>The time CRAS waits
for client reply until timeout.</summary>
Please add an owner tag.

I think it might be a bit cleaner to reword the description as the current
wording reads to me like the value of a constant (e.g. the threshold before we
consider it to be a timeout).

Also, please clarify in the description when this is recorded - is it any time
there is a CRAS timeout?

[hychao, 2014-05-21 06:59:12]

https://codereview.chromium.org/293543004/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/293543004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:1873: +  <summary>The time CRAS waits
for client reply until timeout.</summary>
On 2014/05/21 06:04:15, Alexei Svitkine wrote:
> Please add an owner tag.
> 
> I think it might be a bit cleaner to reword the description as the current
> wording reads to me like the value of a constant (e.g. the threshold before we
> consider it to be a timeout).
> 
> Also, please clarify in the description when this is recorded - is it any time
> there is a CRAS timeout?

Done. What is a owner tag? I have claimed for this UMA histogram, is that
something I should add in the xml?  Thanks!

[Alexei Svitkine (slow), 2014-05-21 07:17:44]

Thanks.

LGTM % adding yourself as owner to the histogram

https://codereview.chromium.org/293543004/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/293543004/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:1873: +  <summary>The time CRAS waits
for client reply until timeout.</summary>
On 2014/05/21 06:59:13, hychao wrote:
> On 2014/05/21 06:04:15, Alexei Svitkine wrote:
> > Please add an owner tag.
> > 
> > I think it might be a bit cleaner to reword the description as the current
> > wording reads to me like the value of a constant (e.g. the threshold before
we
> > consider it to be a timeout).
> > 
> > Also, please clarify in the description when this is recorded - is it any
time
> > there is a CRAS timeout?
> 
> Done. What is a owner tag? I have claimed for this UMA histogram, is that
> something I should add in the xml?  Thanks!

Yeah, going forward claiming a histogram is equivalent to putting
<owner>yourldap@chromium.org</owner> in the xml file above the summary tag.

[hychao, 2014-05-21 07:52:07]

On 2014/05/21 07:17:44, Alexei Svitkine wrote:
> Thanks.
> 
> LGTM % adding yourself as owner to the histogram
> 
>
https://codereview.chromium.org/293543004/diff/1/tools/metrics/histograms/his...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/293543004/diff/1/tools/metrics/histograms/his...
> tools/metrics/histograms/histograms.xml:1873: +  <summary>The time CRAS waits
> for client reply until timeout.</summary>
> On 2014/05/21 06:59:13, hychao wrote:
> > On 2014/05/21 06:04:15, Alexei Svitkine wrote:
> > > Please add an owner tag.
> > > 
> > > I think it might be a bit cleaner to reword the description as the current
> > > wording reads to me like the value of a constant (e.g. the threshold
before
> we
> > > consider it to be a timeout).
> > > 
> > > Also, please clarify in the description when this is recorded - is it any
> time
> > > there is a CRAS timeout?
> > 
> > Done. What is a owner tag? I have claimed for this UMA histogram, is that
> > something I should add in the xml?  Thanks!
> 
> Yeah, going forward claiming a histogram is equivalent to putting
> <mailto:owner>yourldap@chromium.org</owner> in the xml file above the summary
tag.

Done and thanks!

[hychao, 2014-05-21 07:52:20]

The CQ bit was checked by hychao@chromium.org

[commit-bot: I haz the power, 2014-05-21 07:54:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hychao@chromium.org/293543004/30001

[commit-bot: I haz the power, 2014-05-22 02:35:37]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-05-22 02:55:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 02:55:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[hychao, 2014-05-22 04:11:26]

The CQ bit was checked by hychao@chromium.org

[commit-bot: I haz the power, 2014-05-22 04:12:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hychao@chromium.org/293543004/50001

[commit-bot: I haz the power, 2014-05-22 10:17:38]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-05-22 10:24:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 10:24:15]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[hychao, 2014-05-22 10:48:53]

The CQ bit was checked by hychao@chromium.org

[commit-bot: I haz the power, 2014-05-22 10:50:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hychao@chromium.org/293543004/70001

[commit-bot: I haz the power, 2014-05-22 18:39:32]

Change committed as 272251