Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 293543003: Oilpan: add NeedsAdjustAndMark<T> unit test. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: add NeedsAdjustAndMark<T> unit test. Basic test coverage for the NeedsAdjustAndMark<T> template. R=haraken@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M Source/platform/heap/HeapTest.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look.
6 years, 7 months ago (2014-05-17 19:20:18 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-17 19:21:03 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-17 19:51:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/293543003/1
6 years, 7 months ago (2014-05-17 19:52:10 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 09:04:18 UTC) #5
Message was sent while issue was closed.
Change committed as 174258

Powered by Google App Engine
This is Rietveld 408576698