Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h

Issue 2935413002: [Typed OM] Add comments and consistent structure to all the CSSTransformComponent subclasses (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h b/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h
index cd4f45ff85acbf61caa6d6703e77b6940d66478a..1a2800dc0747f99c39c9c052d8c06bce343eb4b8 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.h
@@ -10,29 +10,33 @@
namespace blink {
-class DOMMatrixReadOnly;
+class DOMMatrix;
+// Represents a matrix value in a CSSTransformValue used for properties like
+// "transform".
+// See CSSMatrixComponent.idl for more information about this class.
class CORE_EXPORT CSSMatrixComponent final : public CSSTransformComponent {
WTF_MAKE_NONCOPYABLE(CSSMatrixComponent);
DEFINE_WRAPPERTYPEINFO();
public:
+ // Constructor defined in the IDL.
static CSSMatrixComponent* Create(DOMMatrixReadOnly*);
+ // Blink-internal ways of creating CSSMatrixComponents.
static CSSMatrixComponent* FromCSSValue(const CSSFunctionValue& value) {
return nullptr;
}
+ // Getters and setters for attributes defined in the IDL.
DOMMatrix* matrix() const { return matrix_; }
-
void setMatrix(DOMMatrix* matrix) { matrix_ = matrix; }
+ // Internal methods - from CSSTransformComponent.
TransformComponentType GetType() const override {
return is2d_ ? kMatrixType : kMatrix3DType;
}
-
DOMMatrix* AsMatrix() const override { return matrix(); }
-
CSSFunctionValue* ToCSSValue() const override;
DEFINE_INLINE_VIRTUAL_TRACE() {

Powered by Google App Engine
This is Rietveld 408576698