Documentation: First App: Added manifest_version line to example code.

Documentation: First App: Added manifest_version line to example code.

This line is required for app manifests, so it should be in the sample
manifest in the tutorial.

BUG=374672
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271513

[scheib, 2014-05-19 04:40:03]

lgtm

[commit-bot: I haz the power, 2014-05-19 04:40:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/293523003/1

[Matt Giuca, 2014-05-19 04:44:37]

The CQ bit was unchecked by mgiuca@chromium.org

[Matt Giuca, 2014-05-19 04:45:42]

Had to stop committing: there's some discussion on the bug that this is not
actually a mandatory field any more:
https://code.google.com/p/chromium/issues/detail?id=374672

[scheib, 2014-05-19 15:10:12]

I'd say doc it anyway for clarity. Implicit magic is confusing. E.g. like
how we know what type of app/ext a manifest is for instead of just calling
it out explicitly.


On Sun, May 18, 2014 at 9:45 PM, <mgiuca@chromium.org> wrote:

> Had to stop committing: there's some discussion on the bug that this is not
> actually a mandatory field any more:
> https://code.google.com/p/chromium/issues/detail?id=374672
>
> https://codereview.chromium.org/293523003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Matt Giuca, 2014-05-19 23:35:58]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-05-19 23:36:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/293523003/1

[commit-bot: I haz the power, 2014-05-19 23:38:35]

Change committed as 271513