Issue 2935223003: Update expectations for closure conversion tests

Issue 2935223003: Update expectations for closure conversion tests (Closed)

Created:
3 years, 6 months ago by Dmitry Stefantsov

Modified:
3 years, 6 months ago

Reviewers:
ahe, karlklose

CC:
reviews_dartlang.org, Kevin Millikin (Google)

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -61 lines)			Patch
M	pkg/kernel/test/closures/closures.status	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	pkg/kernel/testcases/closures/capture_closure.dart.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/kernel/testcases/closures/capture_closure_parameter.dart.expect	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/kernel/testcases/closures/capture_this.dart.expect	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/kernel/testcases/closures/closure_in_constructor.dart.expect	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/kernel/testcases/closures/closure_in_initializer.dart.expect	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/kernel/testcases/closures/closure_in_initializer_closure.dart.expect	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/kernel/testcases/closures/field.dart.expect	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	pkg/kernel/testcases/closures/for_in_closure.dart.expect	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/kernel/testcases/closures/instance_tear_off.dart.expect	View	7 chunks	+12 lines, -12 lines	0 comments	Download
M	pkg/kernel/testcases/closures/named_closure.dart.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/kernel/testcases/closures/type_variables.dart.expect	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/kernel/testcases/closures/uncaptured_for_in_loop.dart.expect	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

Dmitry Stefantsov

It looks like type inference is more precise now, so I updated closure conversion expectation ...

3 years, 6 months ago (2017-06-14 08:24:19 UTC) #2

Dmitry Stefantsov

On 2017/06/14 08:44:10, karlklose wrote: > LGTM As pointed by Karl, it's probably not type ...

3 years, 6 months ago (2017-06-14 09:02:24 UTC) #4

Dmitry Stefantsov

3 years, 6 months ago (2017-06-14 09:03:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
32eed0892df629d0544ceba63e0aa800fc676137 (presubmit successful).