Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8428)

Unified Diff: chrome/browser/resource_coordinator/tab_manager_unittest.cc

Issue 2935183002: [TabMetrics] Add signals that mark the start and end of session restore. (Closed)
Patch Set: Enable SessionRestoreObserverTest only when session service available. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resource_coordinator/tab_manager_unittest.cc
diff --git a/chrome/browser/resource_coordinator/tab_manager_unittest.cc b/chrome/browser/resource_coordinator/tab_manager_unittest.cc
index afec480a603d489f6cbbf8c83a0a5d1a771b14c0..238610c99fd9b59476d9d3d0e6fa86bf0d2c2cee 100644
--- a/chrome/browser/resource_coordinator/tab_manager_unittest.cc
+++ b/chrome/browser/resource_coordinator/tab_manager_unittest.cc
@@ -6,6 +6,7 @@
#include <algorithm>
#include <map>
+#include <memory>
#include <vector>
#include "base/logging.h"
@@ -17,9 +18,11 @@
#include "base/test/simple_test_tick_clock.h"
#include "base/time/time.h"
#include "build/build_config.h"
+#include "chrome/browser/browser_process.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/resource_coordinator/tab_manager_web_contents_data.h"
#include "chrome/browser/resource_coordinator/tab_stats.h"
+#include "chrome/browser/sessions/tab_loader.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/tabs/test_tab_strip_model_delegate.h"
#include "chrome/common/chrome_features.h"
@@ -578,4 +581,24 @@ TEST_F(TabManagerTest, GetUnsortedTabStatsIsInVisibleWindow) {
EXPECT_FALSE(tab_stats[5].is_in_visible_window);
}
+TEST_F(TabManagerTest, OnSessionRestoreStartedAndFinishedLoadingTabs) {
+ std::unique_ptr<content::WebContents> test_contents(
+ WebContentsTester::CreateTestWebContents(browser_context(), nullptr));
+
+ std::vector<SessionRestoreDelegate::RestoredTab> restored_tabs{
+ SessionRestoreDelegate::RestoredTab(test_contents.get(), false, false,
+ false)};
+
+ TabManager* tab_manager = g_browser_process->GetTabManager();
+ EXPECT_FALSE(tab_manager->IsSessionRestoreLoadingTabs());
+
+ TabLoader::RestoreTabs(restored_tabs, base::TimeTicks());
+ EXPECT_TRUE(tab_manager->IsSessionRestoreLoadingTabs());
+
+ WebContentsTester::For(test_contents.get())
+ ->NavigateAndCommit(GURL("about:blank"));
+ WebContentsTester::For(test_contents.get())->TestSetIsLoading(false);
+ EXPECT_FALSE(tab_manager->IsSessionRestoreLoadingTabs());
+}
+
} // namespace resource_coordinator

Powered by Google App Engine
This is Rietveld 408576698